Paragraph about using variables in I18n translations was added to I18n Guide #3044

Closed
wants to merge 1,206 commits into
from

Conversation

Projects
None yet
@kirs
Member

kirs commented Sep 16, 2011

No description provided.

josh and others added some commits Aug 24, 2011

Make ActionController::TestCase#recycle! set @protocol to nil
This ensures that the protocol does not get carried over when there are
two or more requests in functional tests. This was a problem when e.g.
the first request was HTTP and the second request was HTTPS.

Closes #2654.

Signed-off-by: Andrew White <andyw@pixeltrix.co.uk>
Merge pull request #2677 from guilleiguaran/refactor-sprockets-helpers
Refactoring javascript_include_tag and stylesheet_link_tag Sprockets helpers
@rubys

This comment has been minimized.

Show comment
Hide comment
@rubys

rubys Aug 25, 2011

Contributor

Isn't that missing a splat?

$ irb
irb(main):001:0> Hash[[1,2]]
=> {}
irb(main):002:0> Hash[*[1,2]]
=> {1=>2}
irb(main):003:0>

Isn't that missing a splat?

$ irb
irb(main):001:0> Hash[[1,2]]
=> {}
irb(main):002:0> Hash[*[1,2]]
=> {1=>2}
irb(main):003:0>

This comment has been minimized.

Show comment
Hide comment
@tenderlove

tenderlove Aug 25, 2011

Member

No, it's a list of lists:

irb(main):001:0> Hash[[[1,2]]]
=> {1=>2}
irb(main):002:0>
Member

tenderlove replied Aug 25, 2011

No, it's a list of lists:

irb(main):001:0> Hash[[[1,2]]]
=> {1=>2}
irb(main):002:0>

arunagw and others added some commits Aug 25, 2011

Yes we need this to pass the test. we are using config.log_level.
Fix broken test test_copying_migrations(RailtiesTest::EngineTest):
NoMethodError: undefined method `log_level' for #<Rails::Engine::Configuration:0xb87a98c>
Merge pull request #2696 from guilleiguaran/string-keys-sprockets-hel…
…pers

Removing redundant stringify_keys in Sprockets helpers
Force binary data inserted for a string data type to utf-8 and log an
error.  Strings tagged as binary will be stored in sqlite3 as blobs.  It
is an error to insert binary data to a string column, so an error is
emitted in the log file.  People are highly encouraged to track down the
source of the binary strings and make sure that the encoding is set
correctly before inserting to the database.

spastorino and others added some commits Sep 12, 2011

Merge pull request #2936 from joelmoss/migration_status
db:migrate:status not looking at all migration paths
Merge pull request #2983 from sikachu/3-1-stable-hash-backported
Issue #636 - Parsing an xml file with multiple records and extra attribut
Merge pull request #2997 from guilleiguaran/move-assets-test-3-1-stable
Backport e767cda (move assets tests to assets_test file) to 3-1-stable
merged the contribution guides and changed the
link in the layout accordingly
Merge pull request #2922 from wayneeseguin/master
Include ActiveRecord SQLServer Adapter by @metaskills in new application generator.
Merge pull request #3011 from guilleiguaran/disable-sprockets-server
Don't mount Sprockets if config.assets.compile is disabled
Revert "Provide a way to access to assets without using the digest, u…
…seful for static files and emails"

This reverts commit 82afaa0.
Merge pull request #3012 from guilleiguaran/3-1-1-changelogs
Add missing changelog entries for actionpack
Merge pull request #3015 from guilleiguaran/clear-tmp-cache-on-precom…
…pile

Clear cache before of each precompile to avoid inconsistencies. Fixes #3014
Allow asset tag helper methods to accept :digest => false option in o…
…rder to completely avoid the digest generation.
@dmathieu

This comment has been minimized.

Show comment
Hide comment
@dmathieu

dmathieu Sep 16, 2011

Contributor

Please close this issue. @kirs : you need to "change commits" when you create the pull request, so it tracks the 3-1-stable branch.

Contributor

dmathieu commented Sep 16, 2011

Please close this issue. @kirs : you need to "change commits" when you create the pull request, so it tracks the 3-1-stable branch.

@vijaydev

This comment has been minimized.

Show comment
Hide comment
@vijaydev

vijaydev Sep 16, 2011

Member

@kirs This is a bad PR. You've to ensure only your commit is in the PR. A better thing to do would be, as I mentioned earlier, do this commit in docrails.

Member

vijaydev commented Sep 16, 2011

@kirs This is a bad PR. You've to ensure only your commit is in the PR. A better thing to do would be, as I mentioned earlier, do this commit in docrails.

@vijaydev vijaydev closed this Sep 16, 2011

@pixeltrix

This comment has been minimized.

Show comment
Hide comment
@pixeltrix

pixeltrix Sep 17, 2011

Member

Is thiis right? I have to use the image-url helper to get fingerprints added - the underscore helpers don't add fingerprints.

Member

pixeltrix commented on 7e587c2 Sep 17, 2011

Is thiis right? I have to use the image-url helper to get fingerprints added - the underscore helpers don't add fingerprints.

This comment has been minimized.

Show comment
Hide comment
@ugisozols

ugisozols Sep 17, 2011

Contributor

I just tested it and it was working either way... anyway I changed it back and added more info based on sass-rails readme.

Contributor

ugisozols replied Sep 17, 2011

I just tested it and it was working either way... anyway I changed it back and added more info based on sass-rails readme.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment