Ignores a default subclass when becomes(Parent)
#30535
Conversation
|
Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @schneems (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. This repository is being automatically checked for code quality issues using Code Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a Pull Request is considered ready to review. Please see the contribution instructions for more information. |
leonelgalan
force-pushed
the
becomes_and_default_inheritance
branch
from
7065c98
to
950fdf6
Compare
|
After the original issue was marked as stale I've confirmed this is still an issue in Rails 5.1.4 and 5.2.0.beta2. I rebased this PR to make it easier for reviewers. |
Fixes issue described in rails#30399: A default value on the inheritance column prevented `child.becomes(Parent)` to return an instance of `Parent` as expected, instead it returns an instance of the default subclass. The change was introduced by rails#17169 and it was meant to affect initialization, alone. Where `Parent.new` is expected to return an instance of the default subclass.
leonelgalan
force-pushed
the
becomes_and_default_inheritance
branch
from
56c96c4
to
3562331
Compare
|
Squashed and rebased, thanks for your help! |
Summary
Fixes issue described in #30399: A default value on the
inheritance column prevented
child.becomes(Parent)to returnan instance of
Parentas expected, instead it returns an instanceof the default subclass.
The change was introduced by #17169 and it was meant to affect
initialization, alone. Where
Parent.newis expected to returnan instance of the default subclass.