New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update payload names for `sql.active_record` instrumentation to be more descriptive. #30619

Merged
merged 1 commit into from Sep 20, 2017

Conversation

Projects
None yet
3 participants
@jagthedrummer
Contributor

jagthedrummer commented Sep 16, 2017

Summary

This updates payload names of sql.active_record instrumentation for create, update, and destroy operations to match the pattern set up by find and count operations.

Previous behavior:

  • When a Book is created the payload name was "SQL".
  • When a Book is updated the payload name was "SQL".
  • When a Book is deleted the payload name was "SQL".

New behavior:

  • When a Book is created the payload name is "Book Create".
  • When a Book is updated the payload name is "Book Update".
  • When a Book is deleted the payload name is "Book Delete".

Fixes #30586.

Other Information

Thread from the rails core mailing list: https://groups.google.com/forum/#!topic/rubyonrails-core/yh9lg0nmvOQ

@rails-bot

This comment has been minimized.

rails-bot commented Sep 16, 2017

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @eileencodes (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

This repository is being automatically checked for code quality issues using Code Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a Pull Request is considered ready to review.

Please see the contribution instructions for more information.

@jagthedrummer jagthedrummer changed the title from Update payload names for `sql.active_record` to be more descriptive. to Update payload names for `sql.active_record` instrumentation to be more descriptive. Sep 16, 2017

@eileencodes

This comment has been minimized.

Member

eileencodes commented Sep 20, 2017

@jagthedrummer thanks for the PR. This looks good. Can you squash your commits into 1 please? Thanks!

@jagthedrummer

This comment has been minimized.

Contributor

jagthedrummer commented Sep 20, 2017

Hey, @eileencodes, thanks for taking a look. I just squashed everything, so I think it should be ready to go now. Cheers!

@eileencodes eileencodes merged commit 55e50f7 into rails:master Sep 20, 2017

2 checks passed

codeclimate All good!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@eileencodes

This comment has been minimized.

Member

eileencodes commented Sep 20, 2017

Congrats on your first Rails contribution! 😄 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment