Update payload names for sql.active_record instrumentation to be more descriptive.
#30619
Conversation
|
Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @eileencodes (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. This repository is being automatically checked for code quality issues using Code Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a Pull Request is considered ready to review. Please see the contribution instructions for more information. |
jagthedrummer
changed the title
sql.active_record to be more descriptive.sql.active_record instrumentation to be more descriptive.
|
@jagthedrummer thanks for the PR. This looks good. Can you squash your commits into 1 please? Thanks! |
jagthedrummer
force-pushed
the
jeremy/instrumentation-payload-names
branch
from
683aedf
to
fda9df7
Compare
|
Hey, @eileencodes, thanks for taking a look. I just squashed everything, so I think it should be ready to go now. Cheers! |
|
Congrats on your first Rails contribution! 😄 🎉 |
The payload name for `delete_all` was named "Destroy" in rails#30619 since `delete_all` was used in `record.destroy` at that time. Since ea45d56, `record.destroy` no longer relies on `delete_all`, so now we can improve the payload name for `delete_all` to more appropriate.
The payload name for `delete_all` was named "Destroy" in rails#30619 since `delete_all` was used in `record.destroy` at that time. Since ea45d56, `record.destroy` no longer relies on `delete_all`, so now we can improve the payload name for `delete_all` to more appropriate.
The payload name for `delete_all` was named "Destroy" in rails#30619 since `delete_all` was used in `record.destroy` at that time. Since ea45d56, `record.destroy` no longer relies on `delete_all`, so now we can improve the payload name for `delete_all` to more appropriate.
Summary
This updates payload names of
sql.active_recordinstrumentation forcreate,update, anddestroyoperations to match the pattern set up byfindandcountoperations.Previous behavior:
Bookis created the payload name was"SQL".Bookis updated the payload name was"SQL".Bookis deleted the payload name was"SQL".New behavior:
Bookis created the payload name is"Book Create".Bookis updated the payload name is"Book Update".Bookis deleted the payload name is"Book Delete".Fixes #30586.
Other Information
Thread from the rails core mailing list: https://groups.google.com/forum/#!topic/rubyonrails-core/yh9lg0nmvOQ