New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for custom handling of exceptions that are discarded #30622

Merged
merged 2 commits into from Jan 23, 2018

Conversation

Projects
None yet
4 participants
@aidanharan
Copy link
Contributor

aidanharan commented Sep 16, 2017

Allow a job that is discarded to be handled by a custom handler. The retry_on already provides the ability for a custom handler and think discard_on should provide the same for consistency.

@rails-bot

This comment has been minimized.

Copy link

rails-bot commented Sep 16, 2017

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @sgrif (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

This repository is being automatically checked for code quality issues using Code Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a Pull Request is considered ready to review.

Please see the contribution instructions for more information.

@rafaelfranca rafaelfranca merged commit 4cfd40a into rails:master Jan 23, 2018

2 checks passed

codeclimate All good!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@aidanharan aidanharan deleted the aidanharan:custom-discarded-job-handling branch Jan 24, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment