Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mini_magick to default Gemfile as comment #30633

Merged
merged 1 commit into from
Sep 17, 2017

Conversation

yhirano55
Copy link
Contributor

Summary

  • If we want to transform image on ActiveStorage, we should bundle mini_magick.
  • I've added comment block to default Gemfile to be easier to install mini_magick.

* If we want to transform image on ActiveStorage, we should bundle
  `mini_magick`.
* I've added comment block to default `Gemfile` to be easier to install this.
@rails-bot
Copy link

r? @kaspth

(@rails-bot has picked a reviewer for you, use r? to override)

@kamipo kamipo merged commit 45f2aa8 into rails:master Sep 17, 2017
@yhirano55 yhirano55 deleted the add_mini_magick_to_app_generator branch September 17, 2017 15:46
@nynhex
Copy link

nynhex commented Sep 17, 2017

This was a good call, but should also mention in the Gemfile comment that Imagemagick binary is needed to support mini_magick. Just saying.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants