New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow usage of strings as locals for partial renderer #30647

Merged
merged 1 commit into from Apr 27, 2018

Conversation

Projects
None yet
5 participants
@droptheplot
Contributor

droptheplot commented Sep 18, 2017

I tried to pass variables generated in some other place to partial locals like this:

class TestController < ApplicationController
  def index
    render partial: 'test', layout: false, locals: { MyClass.name.underscore => 'my_value' }
  end
end

And found that in this case I won't get a undefined local variable or method exception and my local variable my_class would be equal to nil. Looks like this variable "exists" but value is not set because key is not a symbol in locals hash.

If it wasn't on purpose then I suggest to use symbolize_keys for locals in partial renderer.

@rails-bot

This comment has been minimized.

Show comment
Hide comment
@rails-bot

rails-bot Sep 18, 2017

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @sgrif (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

This repository is being automatically checked for code quality issues using Code Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a Pull Request is considered ready to review.

Please see the contribution instructions for more information.

rails-bot commented Sep 18, 2017

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @sgrif (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

This repository is being automatically checked for code quality issues using Code Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a Pull Request is considered ready to review.

Please see the contribution instructions for more information.

@gmcgibbon

👍 Still a problem in 6.0.0.alpha. Silently assigning nil locals definitely seems like a bug.

@rafaelfranca rafaelfranca merged commit ce58a64 into rails:master Apr 27, 2018

2 checks passed

codeclimate All good!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment