Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement change_table_comment and change_column_comment #30677

Merged
merged 1 commit into from Sep 22, 2017

Conversation

@alecspopa
Copy link
Contributor

@alecspopa alecspopa commented Sep 21, 2017

Implement change_table_comment and change_column_comment for MySql.
The two methods were defined in PR #22911 but only implemented for PostgreSQL.

@rails-bot
Copy link

@rails-bot rails-bot commented Sep 21, 2017

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @kamipo (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

This repository is being automatically checked for code quality issues using Code Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a Pull Request is considered ready to review.

Please see the contribution instructions for more information.

Copy link
Member

@kamipo kamipo left a comment

Can you add tests that comment is dropped if comment is nil?

activerecord/lib/active_record/connection_adapters/abstract_mysql_adapter.rb Outdated
@@ -365,6 +370,12 @@ def change_column_null(table_name, column_name, null, default = nil) #:nodoc:
change_column table_name, column_name, column.sql_type, null: null
end

# Adds comment for given table column or drops it if +comment+ is a +nil+
def change_column_comment(table_name, column_name, comment)

This comment has been minimized.

@kamipo

kamipo Sep 21, 2017
Member

Add # :nodoc:.

activerecord/lib/active_record/connection_adapters/abstract_mysql_adapter.rb Outdated
@@ -311,6 +311,11 @@ def bulk_change_table(table_name, operations) #:nodoc:
execute("ALTER TABLE #{quote_table_name(table_name)} #{sqls}")
end

# Adds comment for given table or drops it if +comment+ is a +nil+
def change_table_comment(table_name, comment)

This comment has been minimized.

@kamipo

kamipo Sep 21, 2017
Member

Add # :nodoc:.

@alecspopa
Copy link
Contributor Author

@alecspopa alecspopa commented Sep 21, 2017

Sure, I'll add the test for update to nil.

@kamipo
Copy link
Member

@kamipo kamipo commented Sep 21, 2017

Can you squash your commits into 1 please?

@alecspopa alecspopa force-pushed the alecspopa:master branch to 72a22fa Sep 22, 2017
@alecspopa
Copy link
Contributor Author

@alecspopa alecspopa commented Sep 22, 2017

Done. Thank you for your review.

@kamipo kamipo merged commit a0277a9 into rails:master Sep 22, 2017
2 checks passed
2 checks passed
codeclimate All good!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@kamipo
Copy link
Member

@kamipo kamipo commented Sep 22, 2017

Thanks!

bogdanvlviv added a commit to bogdanvlviv/rails that referenced this pull request Oct 4, 2017
Implemented by rails#22911
Related to rails#30677
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.