jdbcpostgresql support added into template. #307

Closed
wants to merge 2 commits into from

3 participants

@arunagw
Ruby on Rails member

All major three done and tested (mysql, sqlite3, postgresql)

Thanks :-)

@vijaydev vijaydev commented on the diff Apr 26, 2011
...ils/app/templates/config/databases/jdbcpostgresql.yml
@@ -0,0 +1,48 @@
+# PostgreSQL. Versions 7.4 and 8.x are supported.
+#
+# Install the pg driver:
+# gem install pg
+# On Mac OS X with macports:
+# gem install pg -- --with-pg-config=/opt/local/lib/postgresql84/bin/pg_config
+# On Windows:
+# gem install pg
+# Choose the win32 build.
+# Install PostgreSQL and put its /bin directory on your path.
+development:
+ adapter: jdbcpostgresql
+ encoding: unicode
+ database: <%= app_name %>_development
+ username: <%= app_name %>
@vijaydev
Ruby on Rails member

username set to the app_name doesn't sound right. It can be left empty instead.

@vijaydev
Ruby on Rails member

Fair enough. Any idea why this is done though? It's not a sensible default, is it?

@arunagw
Ruby on Rails member
arunagw added a note Apr 26, 2011

I think it is.

@vijaydev
Ruby on Rails member

Can you explain why ?

@arunagw
Ruby on Rails member
arunagw added a note Apr 26, 2011

I think :
Most of the time like MySQL , Postgres don't have the same user account on system. So instead of leaving blank we use app_name.
As i get to know from search that postgresql default name is depends on how it's setup.

Like for Mysql "root" is the best default.

@vijaydev
Ruby on Rails member

Thanks! But I still am not sure about this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@tenderlove
Ruby on Rails member

Should be merged now. Thanks!

@tenderlove tenderlove closed this Apr 26, 2011
@arunagw arunagw pushed a commit to arunagw/rails that referenced this pull request Apr 26, 2011
@tenderlove tenderlove Merged pull request #307 from arunagw/master.
jdbcpostgresql support added into template.
315f555
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment