New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yield with an error instance instead of error class #30750

Merged
merged 2 commits into from Oct 13, 2017

Conversation

Projects
None yet
4 participants
@k2nr
Contributor

k2nr commented Sep 29, 2017

The code comment says "This block is yielded with the job instance as the first and the error instance as the second parameter." so I think the block should be yielded with an actual error instance instead of error class

@rails-bot

This comment has been minimized.

Show comment
Hide comment
@rails-bot

rails-bot Sep 29, 2017

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @sgrif (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

This repository is being automatically checked for code quality issues using Code Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a Pull Request is considered ready to review.

Please see the contribution instructions for more information.

rails-bot commented Sep 29, 2017

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @sgrif (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

This repository is being automatically checked for code quality issues using Code Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a Pull Request is considered ready to review.

Please see the contribution instructions for more information.

@kamipo

This comment has been minimized.

Show comment
Hide comment
@kamipo

kamipo Sep 29, 2017

Member

Can you add a test case?

Member

kamipo commented Sep 29, 2017

Can you add a test case?

@k2nr

This comment has been minimized.

Show comment
Hide comment
@k2nr

k2nr Oct 13, 2017

Contributor

@kamipo Sorry missed your comment. I just updated the existing test to check an exception message. that test fails with the previous code because the exception class doesn't have message class method. Could you review again?

Contributor

k2nr commented Oct 13, 2017

@kamipo Sorry missed your comment. I just updated the existing test to check an exception message. that test fails with the previous code because the exception class doesn't have message class method. Could you review again?

@kamipo kamipo merged commit a254454 into rails:master Oct 13, 2017

2 checks passed

codeclimate All good!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@kamipo

This comment has been minimized.

Show comment
Hide comment
@kamipo

kamipo Oct 13, 2017

Member

Thanks!

Member

kamipo commented Oct 13, 2017

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment