Add allow_other_host option to redirect_back method #30850
Conversation
|
Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @sgrif (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. This repository is being automatically checked for code quality issues using Code Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a Pull Request is considered ready to review. Please see the contribution instructions for more information. |
| def redirect_back(fallback_location:, **args) | ||
| if referer = request.headers["Referer"] | ||
| def redirect_back(fallback_location:, allow_other_host: true, **args) | ||
| if (referer = request.headers["Referer"]) && (allow_other_host || URI(referer).host == request.host) |
There was a problem hiding this comment.
URI(referer) can raise exceptions. Should we make sure that returns false?
There was a problem hiding this comment.
Indeed, it raises an error on non-string attribute.
So what if I use URI(referer.to_s).host == request.host?
There was a problem hiding this comment.
I think there are more cases where it could raise. I'd prefer to call to_s but also rescue the possible exceptions and return false in those cases.
| @@ -82,8 +82,8 @@ def redirect_to(options = {}, response_status = {}) | |||
| # | |||
| # All options that can be passed to <tt>redirect_to</tt> are accepted as | |||
| # options and the behavior is identical. | |||
| def redirect_back(fallback_location:, **args) | |||
| if referer = request.headers["Referer"] | |||
| def redirect_back(fallback_location:, allow_other_host: true, **args) | |||
There was a problem hiding this comment.
We need to document this new option.
timfjord
force-pushed
the
safe-redirect-back
branch
from
9d30edf to
5c45b22
Compare
|
@rafaelfranca Requested changes are in place. Please take a look |
timfjord
force-pushed
the
safe-redirect-back
branch
from
5c45b22 to
ce38a2b
Compare
| referer = request.headers["Referer"] | ||
| redirect_to_referer = begin | ||
| referer && (allow_other_host || URI(referer.to_s).host == request.host) | ||
| rescue ArgumentError |
There was a problem hiding this comment.
We should also rescue URI:: Error and better to move URI(referer.to_s).host == request.host to a private method.
timfjord
force-pushed
the
safe-redirect-back
branch
from
ce38a2b to
0db6a14
Compare
|
Done. I think we also need to cover bad URL case with tests |
|
@Timsly @rafaelfranca I think we need to add changelog entry |
…_back` method [ci skip] Related to rails#30850
This PR adds
allow_other_hostoption toredirect_backmethodWhen
allow_other_host: falseredirection back to URLs from different host is not allowedallow_other_hostistrueby default to make it backward compatible