Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PhantomJS is abandoned, replace it with Selenium/Chrome headless #30930

Merged
merged 2 commits into from Oct 19, 2017

Conversation

@guilleiguaran
Copy link
Member

@guilleiguaran guilleiguaran commented Oct 19, 2017

PhantomJS was abandoned and Chrome headless is seeing a major adoption:

ariya/phantomjs#15105

@guilleiguaran guilleiguaran self-assigned this Oct 19, 2017
@guilleiguaran guilleiguaran merged commit fce2494 into master Oct 19, 2017
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
codeclimate All good!
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@guilleiguaran guilleiguaran deleted the replace-phantomjs-with-chrome branch Oct 19, 2017
@jasonfb
Copy link

@jasonfb jasonfb commented Oct 23, 2017

PHANTOM JS IS DEAD. LONG LIVE PHANTOM JS


driver_options = Selenium::WebDriver::Chrome::Options.new
driver_options.add_argument('--headless')
driver_options.add_argument('--disable-gpu')

This comment has been minimized.

@vemv

vemv Oct 26, 2017

worth explaining why gpu is disabled

This comment has been minimized.

@vemv

vemv Oct 26, 2017

Thanks!

But I meant, I would have added a comment like

# https://developers.google.com/web/updates/2017/04/headless-chrome#cli indicates this is flag needed for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.