New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecations #30945

Merged
merged 20 commits into from Oct 23, 2017

Conversation

Projects
None yet
3 participants
@rafaelfranca
Member

rafaelfranca commented Oct 20, 2017

Remove all deprecated code from 5.2

@rafaelfranca rafaelfranca self-assigned this Oct 20, 2017

yahonda added a commit to yahonda/oracle-enhanced that referenced this pull request Oct 20, 2017

Remove deprecated passing `name` to `indexes`
Refer rails/rails#26689 for the deprecation
rails/rails#30945 for the removing of the
deprecations

yahonda added a commit to yahonda/oracle-enhanced that referenced this pull request Oct 20, 2017

Show outdated Hide outdated actioncable/README.md
Show outdated Hide outdated activesupport/lib/active_support/callbacks.rb
@@ -437,8 +436,6 @@ def self.build(filter, callback)
case filter
when Symbol
new(nil, filter, [], nil)
when String
new(nil, :instance_exec, [:value], compile_lambda(filter))

This comment has been minimized.

@matthewd

matthewd Oct 20, 2017

Member

Could we put the error here? Would that avoid the duplicated checks below? They feel a bit odd where they are now, because they're checking & complaining about the type of a value those methods are barely using.

@matthewd

matthewd Oct 20, 2017

Member

Could we put the error here? Would that avoid the duplicated checks below? They feel a bit odd where they are now, because they're checking & complaining about the type of a value those methods are barely using.

This comment has been minimized.

@rafaelfranca

rafaelfranca Oct 20, 2017

Member

I'll try but I think this method is executed at runtime not at definition time. But to be fair I didn't tried yet.

@rafaelfranca

rafaelfranca Oct 20, 2017

Member

I'll try but I think this method is executed at runtime not at definition time. But to be fair I didn't tried yet.

This comment has been minimized.

@rafaelfranca

rafaelfranca Oct 20, 2017

Member

Yeah, that is the case. That method is not called in definition time

@rafaelfranca

rafaelfranca Oct 20, 2017

Member

Yeah, that is the case. That method is not called in definition time

This comment has been minimized.

@matthewd

matthewd Oct 20, 2017

Member

Ah, hmm. Do we care? It was important for the deprecation, to report it at the best possible time... but now it's "just" an error. I see the value in not letting it fall through to a confusing NoMethodError on String, but it currently seems a lot more protective than we normally are for wrong argument types.

@matthewd

matthewd Oct 20, 2017

Member

Ah, hmm. Do we care? It was important for the deprecation, to report it at the best possible time... but now it's "just" an error. I see the value in not letting it fall through to a confusing NoMethodError on String, but it currently seems a lot more protective than we normally are for wrong argument types.

This comment has been minimized.

@rafaelfranca

rafaelfranca Oct 20, 2017

Member

Addressed in the Callback initializer.

@rafaelfranca

rafaelfranca Oct 20, 2017

Member

Addressed in the Callback initializer.

@sgrif

sgrif approved these changes Oct 22, 2017

rafaelfranca added some commits Jul 17, 2017

@rafaelfranca rafaelfranca merged commit 8c7aa4c into rails:master Oct 23, 2017

1 check passed

codeclimate All good!
Details

@rafaelfranca rafaelfranca deleted the rafaelfranca:remove-deprecations branch Oct 23, 2017

yahonda added a commit to yahonda/oracle-enhanced that referenced this pull request Oct 23, 2017

yahonda added a commit to yahonda/oracle-enhanced that referenced this pull request Oct 23, 2017

bogdanvlviv added a commit to bogdanvlviv/rails that referenced this pull request Oct 23, 2017

Remove mention about Evented Redis [ci skip]
Evented Redis is removed from Rails.
See #30945
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment