Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecations #30945

Merged
merged 20 commits into from Oct 23, 2017
Merged

Remove deprecations #30945

merged 20 commits into from Oct 23, 2017

Conversation

@rafaelfranca
Copy link
Member

@rafaelfranca rafaelfranca commented Oct 20, 2017

Remove all deprecated code from 5.2

@rafaelfranca rafaelfranca self-assigned this Oct 20, 2017
yahonda added a commit to yahonda/oracle-enhanced that referenced this pull request Oct 20, 2017
Refer rails/rails#26689 for the deprecation
rails/rails#30945 for the removing of the
deprecations
yahonda added a commit to yahonda/oracle-enhanced that referenced this pull request Oct 20, 2017
Revert this commit once rails/rails#30945 merged to master.
actioncable/README.md Outdated
@@ -446,7 +446,7 @@ The WebSocket server doesn't have access to the session, but it has access to th

## Dependencies

Action Cable provides a subscription adapter interface to process its pubsub internals. By default, asynchronous, inline, PostgreSQL, evented Redis, and non-evented Redis adapters are included. The default adapter in new Rails applications is the asynchronous (`async`) adapter. To create your own adapter, you can look at `ActionCable::SubscriptionAdapter::Base` for all methods that must be implemented, and any of the adapters included within Action Cable as example implementations.
Action Cable provides a subscription adapter interface to process its pubsub internals. By default, asynchronous, inline, PostgreSQL, and non-evented Redis adapters are included. The default adapter in new Rails applications is the asynchronous (`async`) adapter. To create your own adapter, you can look at `ActionCable::SubscriptionAdapter::Base` for all methods that must be implemented, and any of the adapters included within Action Cable as example implementations.

This comment has been minimized.

@matthewd

matthewd Oct 20, 2017
Member

I think we should just call this "Redis" now -- drop "non-evented"

activesupport/lib/active_support/callbacks.rb Outdated
options is deprecated and will be removed in Rails 5.2 without
replacement. Pass a symbol for an instance method, or a lambda,
proc or block, instead.
options is not supportted. Pass a symbol for an instance method,

This comment has been minimized.

@matthewd

matthewd Oct 20, 2017
Member

*supported

@@ -437,8 +436,6 @@ def self.build(filter, callback)
case filter
when Symbol
new(nil, filter, [], nil)
when String
new(nil, :instance_exec, [:value], compile_lambda(filter))

This comment has been minimized.

@matthewd

matthewd Oct 20, 2017
Member

Could we put the error here? Would that avoid the duplicated checks below? They feel a bit odd where they are now, because they're checking & complaining about the type of a value those methods are barely using.

This comment has been minimized.

@rafaelfranca

rafaelfranca Oct 20, 2017
Author Member

I'll try but I think this method is executed at runtime not at definition time. But to be fair I didn't tried yet.

This comment has been minimized.

@rafaelfranca

rafaelfranca Oct 20, 2017
Author Member

Yeah, that is the case. That method is not called in definition time

This comment has been minimized.

@matthewd

matthewd Oct 20, 2017
Member

Ah, hmm. Do we care? It was important for the deprecation, to report it at the best possible time... but now it's "just" an error. I see the value in not letting it fall through to a confusing NoMethodError on String, but it currently seems a lot more protective than we normally are for wrong argument types.

This comment has been minimized.

@rafaelfranca

rafaelfranca Oct 20, 2017
Author Member

Addressed in the Callback initializer.

@rafaelfranca rafaelfranca force-pushed the rafaelfranca:remove-deprecations branch 2 times, most recently Oct 20, 2017
@sgrif
sgrif approved these changes Oct 22, 2017
rafaelfranca added 20 commits Jul 17, 2017
…ecord object
…ciations
…nitialize_internal_metadata_table`
…ble_name`
@rafaelfranca rafaelfranca force-pushed the rafaelfranca:remove-deprecations branch to fea8d35 Oct 23, 2017
@rafaelfranca rafaelfranca merged commit 8c7aa4c into rails:master Oct 23, 2017
1 check passed
1 check passed
codeclimate All good!
Details
@rafaelfranca rafaelfranca deleted the rafaelfranca:remove-deprecations branch Oct 23, 2017
yahonda added a commit to yahonda/oracle-enhanced that referenced this pull request Oct 23, 2017
yahonda added a commit to yahonda/oracle-enhanced that referenced this pull request Oct 23, 2017
bogdanvlviv added a commit to bogdanvlviv/rails that referenced this pull request Oct 23, 2017
Evented Redis is removed from Rails.
See rails#30945
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.