New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #to_json for IO objects, fixes #26132 #30953

Merged
merged 1 commit into from Oct 23, 2017

Conversation

Projects
None yet
4 participants
@rohitpaulk
Contributor

rohitpaulk commented Oct 23, 2017

Summary

Fixes #26132.

Before

  • For unreadable IO objects, to_json would raise an IOError
  • For readable IO objects, to_json would cause a side-effect by reading the contents of the stream.

After

IO#to_json returns the to_s representation for both readable and unreadable IO objects.

@rails-bot

This comment has been minimized.

rails-bot commented Oct 23, 2017

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @kamipo (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

This repository is being automatically checked for code quality issues using Code Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a Pull Request is considered ready to review.

Please see the contribution instructions for more information.

@rafaelfranca rafaelfranca merged commit 813f8e3 into rails:master Oct 23, 2017

2 checks passed

codeclimate All good!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

rafaelfranca added a commit that referenced this pull request Oct 23, 2017

Merge pull request #30953 from rohitpaulk/fix-io-to-json
Fix #to_json for IO objects, fixes #26132

@rohitpaulk rohitpaulk deleted the rohitpaulk:fix-io-to-json branch Oct 24, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment