assert_changes should always assert some change
#31011
Conversation
|
Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @sgrif (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. This repository is being automatically checked for code quality issues using Code Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a Pull Request is considered ready to review. Please see the contribution instructions for more information. |
|
I think we should give a specific error mentioning that the value was already the same as the given value to |
|
Can you squash your commits? |
While using `assert_changes`, I came across some unexpected behavior: if you provide a `to:` argument, and the expression matches but didn't actually change, the assertion will pass. The way `assert_changes` reads, I assumed that it would both assert that there was any change at all, _and_ that the expression changed to match my `to:` argument. In the case of just a `from:` argument, `assert_changes` does what I expect as well. It asserts that the before value `=== from` and that the after value changed. My key change is that `assert_changes` will now _always_ assert that expression changes, no matter what combination of `from:` and `to:` arguments
danielma
force-pushed
the
dma/assert-changes-with-to-should-still-assert-change
branch
from
f2887ba to
af0361d
Compare
|
@rafaelfranca done |
…to-should-still-assert-change `assert_changes` should always assert some change
Summary
While using
assert_changes, I came across some unexpected behavior:if you provide a
to:argument, and the expression matches but didn'tactually change, the assertion will pass.
The way
assert_changesreads, I assumed that it would both assertthat there was any change at all, and that the expression changed to
match my
to:argument.In the case of just a
from:argument,assert_changesdoes what Iexpect as well. It asserts that the before value
=== fromand thatthe after value changed.
My key change is that
assert_changeswill now always assert thatexpression changes, no matter what combination of
from:andto:arguments