/ rails Public
assert_changes should always assert some change
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge.
assert_changes, I came across some unexpected behavior:
if you provide a
to:argument, and the expression matches but didn't
actually change, the assertion will pass.
assert_changesreads, I assumed that it would both assert
that there was any change at all, and that the expression changed to
In the case of just a
assert_changesdoes what I
expect as well. It asserts that the before value
=== fromand that
the after value changed.
My key change is that
assert_changeswill now always assert that
expression changes, no matter what combination of