New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent source line wrapping in rescue layout #31013

Merged
merged 1 commit into from Oct 31, 2017

Conversation

Projects
None yet
2 participants
@dgynn
Contributor

dgynn commented Oct 31, 2017

Summary

Long source lines cause line wrapping in the extracted source section of the rescue handler page which can make the line numbers not match up with the source lines.

Other Information

Here are before/after screenshots

error-with-wrapping
error-without-wrapping

Prevent source line wrapping in rescue layout
Long source lines cause line wrapping in the extracted
source section of the rescue handler page which can make
the line numbers not match up with the source lines.

@rafaelfranca rafaelfranca merged commit f545500 into rails:master Oct 31, 2017

2 checks passed

codeclimate All good!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment