Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Execute `ConfirmationValidator` validation when `_confirmation`'s value is `false` #31058

Merged
merged 1 commit into from Nov 6, 2017

Conversation

Projects
None yet
4 participants
@bogdanvlviv
Copy link
Contributor

bogdanvlviv commented Nov 5, 2017

In according to our documentation ConfirmationValidator validation shouldn't be executed only if _confirmation's value is nil.

https://github.com/rails/rails/blob/8a2ee3d8c6921ce34e597658e3f2b43b41423d1d/guides/source/active_record_validations.md#confirmation

# NOTE: This check is performed only if +password_confirmation+ is not
# +nil+. To require confirmation, make sure to add a presence check for
# the confirmation attribute:

@rails-bot

This comment has been minimized.

Copy link

rails-bot commented Nov 5, 2017

r? @eileencodes

(@rails-bot has picked a reviewer for you, use r? to override)

@rafaelfranca rafaelfranca merged commit 9042ced into rails:master Nov 6, 2017

2 checks passed

codeclimate All good!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@bogdanvlviv bogdanvlviv deleted the bogdanvlviv:ConfirmationValidator-with_false_value branch Nov 6, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.