Added option to pass block to link_to_function #3108

Closed
wants to merge 9 commits into
from

Conversation

Projects
None yet
5 participants
@Ninju

Ninju commented Sep 23, 2011

Patch to solve issue here: #3093

Allows you to pass a block to link_to_function (similar to link_to) if the link text is too complex to be passed as a string argument.

Ninju and others added some commits Sep 23, 2011

Merge pull request #3115 from guilleiguaran/refactor-rails-helpers
Remove Sprockets compute_public_path, AV compute_plubic_path can be used
`rake assets:precompile` loads the application but does not initializ…
…e it.

To the app developer, this means configuration add in
config/initializers/* will not be executed.

Plugins developers need to special case their initializers that are
meant to be run in the assets group by adding :group => :assets.

Conflicts:

	railties/CHANGELOG
	railties/test/application/assets_test.rb
@waseem

This comment has been minimized.

Show comment Hide comment
@waseem

waseem Sep 24, 2011

Shouldn't it be <%= link_to_function ..... do %> ? A do is missing.

Shouldn't it be <%= link_to_function ..... do %> ? A do is missing.

@Ninju

This comment has been minimized.

Show comment Hide comment
@Ninju

Ninju Sep 24, 2011

@waseem: Thanks. You're right, there was a 'do' missing, I've added it now.

Ninju commented Sep 24, 2011

@waseem: Thanks. You're right, there was a 'do' missing, I've added it now.

@Ninju

This comment has been minimized.

Show comment Hide comment
@Ninju

Ninju Sep 24, 2011

I think I messed up the pull request somehow.

Ninju commented Sep 24, 2011

I think I messed up the pull request somehow.

@carlosantoniodasilva

This comment has been minimized.

Show comment Hide comment
@carlosantoniodasilva

carlosantoniodasilva Mar 26, 2012

Owner

@Ninju hey... link_to_function is still available in Rails master, so I believe your patch should be still applicable. Would you like to cleanup it agains current master?

@Ninju hey... link_to_function is still available in Rails master, so I believe your patch should be still applicable. Would you like to cleanup it agains current master?

@Ninju

This comment has been minimized.

Show comment Hide comment
@Ninju

Ninju Apr 18, 2012

I am closing this because I've resubmitted it without the extra commits that shouldn't be there (#5886)

Ninju commented Apr 18, 2012

I am closing this because I've resubmitted it without the extra commits that shouldn't be there (#5886)

@Ninju Ninju closed this Apr 18, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment