Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd new error class `QueryCanceled` which will be raised when canceling statement due to user request #31235
Conversation
kamipo
referenced this pull request
Nov 27, 2017
Merged
Rename `TransactionTimeout` to more descriptive `LockWaitTimeout` #31223
kamipo
merged commit 0e2cd3d
into
rails:master
Nov 27, 2017
kamipo
deleted the
kamipo:add_query_canceled_exception
branch
Nov 27, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
kamipo commentedNov 27, 2017
This changes
StatementTimeouttoQueryCanceledfor PostgreSQL.In MySQL, errno 1317 (
ER_QUERY_INTERRUPTED) is only used when thequery is manually cancelled.
But in PostgreSQL,
QUERY_CANCELEDerror code (57014) which is usedStatementTimeoutis also used when the both case. And, we can not tellwhich reason happened.
So I decided to introduce new error class
QueryCanceledcloser to theerror code name.