Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add headless firefox driver to System Tests #31365

Conversation

@bogdanvlviv
Copy link
Contributor

@bogdanvlviv bogdanvlviv commented Dec 7, 2017

Firefox supports headless mode starting with version 56.
This PR adds headless firefox support to System Tests.

r? @eileencodes

Copy link
Member

@guilleiguaran guilleiguaran left a comment

Looking good but I'll wait to @eileencodes for final decision on this 😊

Loading

Copy link
Member

@eileencodes eileencodes left a comment

👍 Looks good.

Loading

@eileencodes eileencodes merged commit e8c3b58 into rails:master Dec 7, 2017
2 checks passed
Loading
@bogdanvlviv
Copy link
Contributor Author

@bogdanvlviv bogdanvlviv commented Dec 7, 2017

@guilleiguaran @eileencodes Thank you for the review!

Loading

@bogdanvlviv bogdanvlviv deleted the add-headless_firefox-driver-to-system_tests branch Dec 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants