Skip to content

Add an :if_not_exists option to create_table#31382

Merged
pixeltrix merged 1 commit intorails:masterfrom
fatkodima:create_table-if_not_exists
Nov 8, 2018
Merged

Add an :if_not_exists option to create_table#31382
pixeltrix merged 1 commit intorails:masterfrom
fatkodima:create_table-if_not_exists

Conversation

@fatkodima
Copy link
Member

This PR updates (it has no activity nearly for 2 years) this #16376 according to master.
r? @maclover7 @arthurnn

@rails-bot
Copy link

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @maclover7 (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

This repository is being automatically checked for code quality issues using Code Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a Pull Request is considered ready to review.

Please see the contribution instructions for more information.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just noticed, whole line should be replaced with force for create_table and same in the next test

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@fatkodima fatkodima force-pushed the create_table-if_not_exists branch 2 times, most recently from 54825d8 to 16e7ac7 Compare December 15, 2017 16:33
@fatkodima fatkodima force-pushed the create_table-if_not_exists branch from 16e7ac7 to a7d421e Compare December 21, 2017 23:14
@fatkodima fatkodima force-pushed the create_table-if_not_exists branch 2 times, most recently from d9213ff to d00c1f9 Compare January 22, 2018 23:54
@fatkodima
Copy link
Member Author

@rafaelfranca Is there any chance to get also this into 5.2?

@fatkodima fatkodima force-pushed the create_table-if_not_exists branch from d00c1f9 to 6e0ff00 Compare November 8, 2018 13:27
@fatkodima
Copy link
Member Author

@pixeltrix Updated this pr.
@sebcioz Kudos for pushing this forward!

@pixeltrix pixeltrix dismissed rafaelfranca’s stale review November 8, 2018 14:43

Requested changes have been made

@pixeltrix pixeltrix merged commit 4fe27cd into rails:master Nov 8, 2018
@pixeltrix
Copy link
Contributor

@fatkodima thanks! 👍

@pedrofurtado
Copy link
Member

@pixeltrix @rafaelfranca It's great to include this in Rails docs 👍

suketa added a commit to suketa/rails_sandbox that referenced this pull request Jul 13, 2019
Add an :if_not_exists option to create_table
rails/rails#31382
@shootingfly
Copy link

Unbelievable! When you create table, you will drop table! Why keep if_exists default to true?
When I migrate from 5.2 to 6.0, this MR drop all tables in stage environment.

@pixeltrix
Copy link
Contributor

@shootingfly I'm unsure what you mean by your comment and I noticed your 👎🏻 on this comment - that reference to drop_table is in a Rails test and not in code that will get executed in an application. Are you saying that you saw all your tables dropped when upgrading from Rails 5.2 to 6.0? If so please open a new issue describing the problem, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants