Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an :if_not_exists option to create_table #31382

Merged
merged 1 commit into from Nov 8, 2018

Conversation

@fatkodima
Copy link
Contributor

@fatkodima fatkodima commented Dec 9, 2017

This PR updates (it has no activity nearly for 2 years) this #16376 according to master.
r? @maclover7 @arthurnn

@rails-bot
Copy link

@rails-bot rails-bot commented Dec 9, 2017

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @maclover7 (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

This repository is being automatically checked for code quality issues using Code Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a Pull Request is considered ready to review.

Please see the contribution instructions for more information.

@@ -123,6 +123,40 @@ def test_migration_version
assert_nothing_raised { ActiveRecord::Migrator.run(:up, MIGRATIONS_ROOT + "/version_check", 20131219224947) }
end

def test_create_table_raises_if_already_exists
connection = Person.connection
connection.drop_table :testings, if_exists: true
Copy link
Contributor Author

@fatkodima fatkodima Dec 9, 2017

Just noticed, whole line should be replaced with force for create_table and same in the next test

Copy link
Member

@rafaelfranca rafaelfranca Dec 12, 2017

👍

@@ -123,6 +123,40 @@ def test_migration_version
assert_nothing_raised { ActiveRecord::Migrator.run(:up, MIGRATIONS_ROOT + "/version_check", 20131219224947) }
end

def test_create_table_raises_if_already_exists
connection = Person.connection
connection.drop_table :testings, if_exists: true
Copy link
Member

@rafaelfranca rafaelfranca Dec 12, 2017

👍

@fatkodima fatkodima force-pushed the create_table-if_not_exists branch 2 times, most recently from 54825d8 to 16e7ac7 Dec 15, 2017
@fatkodima fatkodima force-pushed the create_table-if_not_exists branch from 16e7ac7 to a7d421e Dec 21, 2017
@fatkodima fatkodima force-pushed the create_table-if_not_exists branch 2 times, most recently from d9213ff to d00c1f9 Jan 22, 2018
@fatkodima
Copy link
Contributor Author

@fatkodima fatkodima commented Jan 23, 2018

@rafaelfranca Is there any chance to get also this into 5.2?

@fatkodima fatkodima force-pushed the create_table-if_not_exists branch from d00c1f9 to 6e0ff00 Nov 8, 2018
@fatkodima
Copy link
Contributor Author

@fatkodima fatkodima commented Nov 8, 2018

@pixeltrix Updated this pr.
@sebcioz Kudos for pushing this forward!

@pixeltrix pixeltrix dismissed rafaelfranca’s stale review Nov 8, 2018

Requested changes have been made

@pixeltrix pixeltrix merged commit 4fe27cd into rails:master Nov 8, 2018
2 checks passed
@pixeltrix
Copy link
Member

@pixeltrix pixeltrix commented Nov 8, 2018

@fatkodima thanks! 👍

@pedrofurtado
Copy link
Member

@pedrofurtado pedrofurtado commented Nov 27, 2018

@pixeltrix @rafaelfranca It's great to include this in Rails docs 👍

suketa added a commit to suketa/rails_sandbox that referenced this issue Jul 13, 2019
Add an :if_not_exists option to create_table
rails/rails#31382
@shootingfly
Copy link

@shootingfly shootingfly commented Jan 19, 2021

Unbelievable! When you create table, you will drop table! Why keep if_exists default to true?
When I migrate from 5.2 to 6.0, this MR drop all tables in stage environment.

@pixeltrix
Copy link
Member

@pixeltrix pixeltrix commented May 8, 2021

@shootingfly I'm unsure what you mean by your comment and I noticed your 👎🏻 on this comment - that reference to drop_table is in a Rails test and not in code that will get executed in an application. Are you saying that you saw all your tables dropped when upgrading from Rails 5.2 to 6.0? If so please open a new issue describing the problem, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

8 participants