Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an :if_not_exists option to create_table #31382

Merged
merged 1 commit into from Nov 8, 2018

Conversation

Projects
None yet
7 participants
@fatkodima
Copy link
Contributor

commented Dec 9, 2017

This PR updates (it has no activity nearly for 2 years) this #16376 according to master.
r? @maclover7 @arthurnn

@rails-bot

This comment has been minimized.

Copy link

commented Dec 9, 2017

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @maclover7 (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

This repository is being automatically checked for code quality issues using Code Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a Pull Request is considered ready to review.

Please see the contribution instructions for more information.

activerecord/test/cases/migration_test.rb Outdated
@@ -123,6 +123,40 @@ def test_migration_version
assert_nothing_raised { ActiveRecord::Migrator.run(:up, MIGRATIONS_ROOT + "/version_check", 20131219224947) }
end

def test_create_table_raises_if_already_exists
connection = Person.connection
connection.drop_table :testings, if_exists: true

This comment has been minimized.

Copy link
@fatkodima

fatkodima Dec 9, 2017

Author Contributor

Just noticed, whole line should be replaced with force for create_table and same in the next test

This comment has been minimized.

Copy link
@rafaelfranca
activerecord/test/cases/migration_test.rb Outdated
@@ -123,6 +123,40 @@ def test_migration_version
assert_nothing_raised { ActiveRecord::Migrator.run(:up, MIGRATIONS_ROOT + "/version_check", 20131219224947) }
end

def test_create_table_raises_if_already_exists
connection = Person.connection
connection.drop_table :testings, if_exists: true

This comment has been minimized.

Copy link
@rafaelfranca

@fatkodima fatkodima force-pushed the fatkodima:create_table-if_not_exists branch 2 times, most recently Dec 13, 2017

@fatkodima fatkodima force-pushed the fatkodima:create_table-if_not_exists branch Dec 21, 2017

@fatkodima fatkodima force-pushed the fatkodima:create_table-if_not_exists branch 2 times, most recently to d00c1f9 Jan 20, 2018

@fatkodima

This comment has been minimized.

Copy link
Contributor Author

commented Jan 23, 2018

@rafaelfranca Is there any chance to get also this into 5.2?

Add an :if_not_exists option to create_table
[fatkodima & Stefan Kanev]

@fatkodima fatkodima force-pushed the fatkodima:create_table-if_not_exists branch from d00c1f9 to 6e0ff00 Nov 8, 2018

@fatkodima

This comment has been minimized.

Copy link
Contributor Author

commented Nov 8, 2018

@pixeltrix Updated this pr.
@sebcioz Kudos for pushing this forward!

Requested changes have been made

@pixeltrix pixeltrix merged commit 4fe27cd into rails:master Nov 8, 2018

2 checks passed

codeclimate All good!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@pixeltrix

This comment has been minimized.

Copy link
Member

commented Nov 8, 2018

@fatkodima thanks! 👍

@pedrofurtado

This comment has been minimized.

Copy link

commented Nov 27, 2018

@pixeltrix @rafaelfranca It's great to include this in Rails docs 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.