Add an :if_not_exists option to create_table#31382
Conversation
|
Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @maclover7 (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. This repository is being automatically checked for code quality issues using Code Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a Pull Request is considered ready to review. Please see the contribution instructions for more information. |
There was a problem hiding this comment.
Just noticed, whole line should be replaced with force for create_table and same in the next test
54825d8 to
16e7ac7
Compare
16e7ac7 to
a7d421e
Compare
d9213ff to
d00c1f9
Compare
|
@rafaelfranca Is there any chance to get also this into 5.2? |
[fatkodima & Stefan Kanev]
d00c1f9 to
6e0ff00
Compare
|
@pixeltrix Updated this pr. |
Requested changes have been made
|
@fatkodima thanks! 👍 |
|
@pixeltrix @rafaelfranca It's great to include this in Rails docs 👍 |
Add an :if_not_exists option to create_table rails/rails#31382
|
Unbelievable! When you create table, you will drop table! Why keep if_exists default to true? |
|
@shootingfly I'm unsure what you mean by your comment and I noticed your 👎🏻 on this comment - that reference to |
This PR updates (it has no activity nearly for 2 years) this #16376 according to master.
r? @maclover7 @arthurnn