Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove verbose_query_logs from new_framework_defaults_5_2.rb #31519

Merged
merged 1 commit into from Dec 20, 2017

Conversation

Projects
None yet
4 participants
@eugeneius
Copy link
Member

eugeneius commented Dec 20, 2017

Followup to #26815; see #26815 (comment).

The app:update rake task will regenerate development.rb so that it contains this option; that means we're currently adding it to existing apps in two places, which is unnecessary and confusing.

Also:

  • Remove inaccurate comment about which stack frames are ignored (see #26815 (comment))
  • Clarify that the feature uses caller_locations, not caller
  • Remove unused return value in extract_callstack
Remove verbose_query_logs from new_framework_defaults_5_2.rb
The `app:update` rake task will regenerate `development.rb` so that it
contains this option; that means we're currently adding it to existing
apps in two places, which is unnecessary and confusing.

Also:
 - Remove inaccurate comment about which stack frames are ignored
 - Clarify that the feature uses `caller_locations`, not `caller`
 - Remove unused return value in `extract_callstack`
@rails-bot

This comment has been minimized.

Copy link

rails-bot commented Dec 20, 2017

r? @eileencodes

(@rails-bot has picked a reviewer for you, use r? to override)

@kamipo kamipo merged commit a8cabf3 into rails:master Dec 20, 2017

2 checks passed

codeclimate All good!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.