New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI against ruby 2.5.0 #31570

Merged
merged 1 commit into from Dec 27, 2017

Conversation

Projects
None yet
3 participants
@y-yagi
Member

y-yagi commented Dec 27, 2017

No description provided.

@sikachu

I have one question, but otherwise this looks good. CI looks to be passing as well.

- ruby-head
matrix:
include:
- rvm: 2.4.2
- rvm: 2.5.0

This comment has been minimized.

@sikachu

sikachu Dec 27, 2017

Member

Do you think we should duplicate this block so we're testing av:ujs on both 2.4 and 2.5?

@sikachu

sikachu Dec 27, 2017

Member

Do you think we should duplicate this block so we're testing av:ujs on both 2.4 and 2.5?

This comment has been minimized.

@matthewd

matthewd Dec 27, 2017

Member

I think this is good; that test is limited to a single version because it's mostly testing JS behaviour, not anything special about 2.4+.

@matthewd

matthewd Dec 27, 2017

Member

I think this is good; that test is limited to a single version because it's mostly testing JS behaviour, not anything special about 2.4+.

@matthewd matthewd merged commit ba56518 into rails:master Dec 27, 2017

2 checks passed

codeclimate All good!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@y-yagi y-yagi deleted the y-yagi:ci_against_250 branch Dec 27, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment