Allow the use of callable objects as group methods for grouped selects. #31578
Conversation
Replaced the uses of `group.send(...)` in `option_groups_from_collection_for_select` by calls to `value_for_collection(group, ...)`, allowing the use of procs, lambdas and other callable objects as parameters.
|
Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @kaspth (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. This repository is being automatically checked for code quality issues using Code Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a Pull Request is considered ready to review. Please see the contribution instructions for more information. |
|
Seems legit. Thanks! |
|
My pleasure |
The
option_groups_from_collection_for_selecthelper could only take method names asgroup_methodandgroup_label_methodparameters. This wasn't consistent withoption_from_collection_for_selectwhich could take either method names or callable objects.This PR replaces the uses of
group.send(...)in the helper by calls tovalue_for_collection(group, ...), allowing the use of procs, lambdas and other callable objects as parameters.