Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow the use of callable objects as group methods for grouped selects. #31578

Conversation

@Aquaj
Copy link
Contributor

@Aquaj Aquaj commented Dec 27, 2017

The option_groups_from_collection_for_select helper could only take method names as group_method and group_label_method parameters. This wasn't consistent with option_from_collection_for_select which could take either method names or callable objects.

This PR replaces the uses of group.send(...) in the helper by calls to value_for_collection(group, ...), allowing the use of procs, lambdas and other callable objects as parameters.

Replaced the uses of `group.send(...)` in `option_groups_from_collection_for_select`
by calls to `value_for_collection(group, ...)`, allowing the use of
procs, lambdas and other callable objects as parameters.
@rails-bot
Copy link

@rails-bot rails-bot commented Dec 27, 2017

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @kaspth (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

This repository is being automatically checked for code quality issues using Code Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a Pull Request is considered ready to review.

Please see the contribution instructions for more information.

@georgeclaghorn
Copy link
Member

@georgeclaghorn georgeclaghorn commented Dec 30, 2017

Seems legit. Thanks!

@georgeclaghorn georgeclaghorn merged commit 35e9638 into rails:master Dec 30, 2017
2 checks passed
2 checks passed
codeclimate All good!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Aquaj
Copy link
Contributor Author

@Aquaj Aquaj commented Dec 30, 2017

My pleasure 😄

@Aquaj Aquaj deleted the Aquaj:feature/allow-callables-in-select-group-methods branch Dec 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants