Fix transaction reverting for migrations

[fatkodima]

Commands than run inside a transaction block in a reverted migration ran uninverted, as is.
So, e.g. reverting this a bit contrived migration will fail:

class CreateComments < ActiveRecord::Migration[5.2]
  def change
    transaction do
      create_table :posts do |t|
        t.string :title
        t.text :body

        t.timestamps
      end
    end
  end
end

But, intuitively, it should be reverted and table should be removed.

This change fixes that problems with uninverted transaction blocks.

Originates from outdated #22141 and addresses only new migrations.

[rails-bot]

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @eileencodes (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

This repository is being automatically checked for code quality issues using Code Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a Pull Request is considered ready to review.

Please see the contribution instructions for more information.

[eileencodes]

Looking at the original PR dv goes by "David Verhasselt" in the CHANGELOG so can you update that for consistecy?

Also can you update your commit to add the following so that he gets the commit credit in the contributors app too?

commit message text

[fatkodima & David Verhasselt]

[fatkodima]

@eileencodes thank you for review. Fixed your notes.
Is there anything that I should do?

[gmcgibbon]

Still relevant in Rails 6 (0a4c2d4). Please rebase and move your compatibility changes to V5_2.

[gmcgibbon]

Are we able to use #public_send here?

[fatkodima]

Unfortunately, no. For example, this method

rails/activerecord/lib/active_record/migration/command_recorder.rb

Line 116 in 6556898

execute_block: :execute_block,

is private.

[gmcgibbon]

You should move these changes to the V5_2 class now that V6_0 is current.

[fatkodima]

Done.