Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix multiline expression indexes for postgresql #31621

Merged

Conversation

@fatkodima
Copy link
Contributor

@fatkodima fatkodima commented Jan 2, 2018

Fixes #31406.

@rails-bot
Copy link

@rails-bot rails-bot commented Jan 2, 2018

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @georgeclaghorn (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

This repository is being automatically checked for code quality issues using Code Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a Pull Request is considered ready to review.

Please see the contribution instructions for more information.

@fatkodima fatkodima force-pushed the fatkodima:postgres-multiline-expression-indexes branch 5 times, most recently Jan 2, 2018
@fatkodima fatkodima force-pushed the fatkodima:postgres-multiline-expression-indexes branch Jan 10, 2018
@fatkodima fatkodima force-pushed the fatkodima:postgres-multiline-expression-indexes branch Jan 20, 2018
@matthewd
Copy link
Member

@matthewd matthewd commented Feb 20, 2018

Could this cause problems if an expression contains a string literal with a newline?

Perhaps we want to add a /m flag to the regexp instead?

@fatkodima fatkodima force-pushed the fatkodima:postgres-multiline-expression-indexes branch to 15a900e Feb 20, 2018
@fatkodima
Copy link
Contributor Author

@fatkodima fatkodima commented Feb 20, 2018

@matthewd Sure! Updated.

@georgeclaghorn
Copy link
Member

@georgeclaghorn georgeclaghorn commented Feb 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants