Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Deprecate `update_attributes` and `update_attributes!` #31998
This would be a desirable change because:
Is this still the intention?
Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @schneems (or someone else) soon.
If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.
This repository is being automatically checked for code quality issues using Code Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a Pull Request is considered ready to review.
Please see the contribution instructions for more information.
Are these aliases causing some sort of maintenance burden? If we actually fully deprecate/remove these methods we are breaking a lot of code for virtually no reason. I'm all for keeping them soft-deprecated, but if they aren't causing a maintenance burden I see no reason to actually remove them.
referenced this pull request
Feb 20, 2019
Just chiming in to raise the same concerns as @sgrif - I think removing these methods could break a significant amount of code in so many gems, and that feels unwise to me.
I personally didn't know