New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let select render default selected option for required field #32087

Merged
merged 1 commit into from Feb 28, 2018

Conversation

Projects
None yet
4 participants
@prikha
Contributor

prikha commented Feb 22, 2018

Summary

Let select tag be required and have a selected disabled placeholder option.

Closes related issue #32080

@rails-bot

This comment has been minimized.

Show comment
Hide comment
@rails-bot

rails-bot Feb 22, 2018

r? @georgeclaghorn

(@rails-bot has picked a reviewer for you, use r? to override)

rails-bot commented Feb 22, 2018

r? @georgeclaghorn

(@rails-bot has picked a reviewer for you, use r? to override)

Show outdated Hide outdated actionview/lib/action_view/helpers/tags/base.rb Outdated
@prikha

This comment has been minimized.

Show comment
Hide comment
@prikha

prikha Feb 23, 2018

Contributor

@rafaelfranca updated to match code style

Contributor

prikha commented Feb 23, 2018

@rafaelfranca updated to match code style

@rafaelfranca

This comment has been minimized.

Show comment
Hide comment
@rafaelfranca

rafaelfranca Feb 23, 2018

Member

Makes sense to me. Can you add a CHANGELOG entry?

Member

rafaelfranca commented Feb 23, 2018

Makes sense to me. Can you add a CHANGELOG entry?

@prikha

This comment has been minimized.

Show comment
Hide comment
@prikha
Contributor

prikha commented Feb 24, 2018

@rafaelfranca

This comment has been minimized.

Show comment
Hide comment
@rafaelfranca

rafaelfranca Feb 27, 2018

Member

Can you squash the commit?

Member

rafaelfranca commented Feb 27, 2018

Can you squash the commit?

@prikha

This comment has been minimized.

Show comment
Hide comment
@prikha

prikha Feb 27, 2018

Contributor
Contributor

prikha commented Feb 27, 2018

@rafaelfranca rafaelfranca merged commit a14a6b8 into rails:master Feb 28, 2018

2 checks passed

codeclimate All good!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@prikha prikha deleted the prikha:add-better-select-tag-option-handling branch Feb 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment