Don't enforce UTF-8 by default #32125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pixeltrix
commented
Feb 27, 2018
| @@ -1519,10 +1519,10 @@ def range_field(object_name, method, options = {}) | |||
|
|
|||
| private | |||
| def html_options_for_form_with(url_for_options = nil, model = nil, html: {}, local: !form_with_generates_remote_forms, | |||
| skip_enforcing_utf8: false, **options) | |||
| skip_enforcing_utf8: nil, **options) | |||
There was a problem hiding this comment.
No happy about changing this but to leave it as false would mean extra logic in this method to extract the default setting.
matthewd
approved these changes
Feb 27, 2018
| # Read the Guide for Upgrading Ruby on Rails for more info on each option. | ||
|
|
||
| # Don't force requests from old versions of IE to be UTF-8 encoded | ||
| # Rails.application.config.action_controller.default_enforce_utf8 = false |
There was a problem hiding this comment.
we need to add the new config to the configuring.md guide.
With the disabling of TLS 1.0 by most major websites, continuing to run IE8 or lower becomes increasingly difficult so default to not enforcing UTF-8 encoding as it's not relevant to other browsers.
pixeltrix
force-pushed
the
switch-to-not-enforcing-utf8-by-default
branch
from
91a66b6
to
96eeea5
Compare
bogdanvlviv
added a commit
to bogdanvlviv/rails
that referenced
this pull request
Feb 27, 2018
`default_enforce_utf8` belongs to `config.action_view` Update info about `:skip_enforcing_utf8` since we can change default behavior via `config.action_controller.default_enforce_utf8` Related to rails#32125
bogdanvlviv
added a commit
to bogdanvlviv/rails
that referenced
this pull request
Aug 27, 2018
This commit is the next work after rails#33523. Also, this commit removes mention about hidden `utf8` input. Since form helpers don't generate this input by default since rails#32125. Note that I also had created PR rails#31972 with improvements to "Action View Form Helpers" guide, but I'll rebase it after merging the current PR.
bogdanvlviv
added a commit
to bogdanvlviv/rails
that referenced
this pull request
Jan 5, 2019
- config.load_defaults 6.0 in the dummy app and fix the test since by default rails 6.0 configured not to generate "utf8" hidden input, see rails#32125 - Use `ActiveRecord::Migration[6.0]` in the dummy app since actiontext will be since Rails 6.0 - Fix `CreateActiveStorageTables` migration in the dummy app. Add `t.foreign_key :active_storage_blobs, column: :blob_id` It was added in 2ae3a29. - `rails/actiontext$ yarn install`
bogdanvlviv
added a commit
to bogdanvlviv/rails
that referenced
this pull request
Jan 5, 2019
- config.load_defaults 6.0 in the dummy app and fix the test since by default rails 6.0 configured does not generate "utf8" hidden input, see rails#32125 - Use `ActiveRecord::Migration[6.0]` in the dummy app since actiontext will be since Rails 6.0 - Fix `CreateActiveStorageTables` migration in the dummy app. Add `t.foreign_key :active_storage_blobs, column: :blob_id` It was added in 2ae3a29. - `rails/actiontext$ yarn install`
bogdanvlviv
added a commit
to bogdanvlviv/rails
that referenced
this pull request
Jan 5, 2019
- config.load_defaults 6.0 in the dummy app and fix the test since by default rails 6.0 configured does not generate "utf8" hidden input, see rails#32125 - Use `ActiveRecord::Migration[6.0]` in the dummy app since actiontext will be since Rails 6.0 - Fix `CreateActiveStorageTables` migration in the dummy app. Add `t.foreign_key :active_storage_blobs, column: :blob_id` It was added in 2ae3a29. - `rails/actiontext$ yarn install`
bogdanvlviv
added a commit
to bogdanvlviv/rails
that referenced
this pull request
Jan 5, 2019
- config.load_defaults 6.0 in the dummy app and fix the test since by default rails 6.0 configured does not generate "utf8" hidden input, see rails#32125 - Use `ActiveRecord::Migration[6.0]` in the dummy app since actiontext will be since Rails 6.0 - Fix `CreateActiveStorageTables` migration in the dummy app. Add `t.foreign_key :active_storage_blobs, column: :blob_id` It was added in 2ae3a29. - `rails/actiontext$ yarn install`
This was referenced Jan 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
With the disabling of TLS 1.0 by most major websites, continuing to run IE8 or lower becomes increasingly difficult so default to not enforcing UTF-8 encoding as it's not relevant to other browsers.