New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Faktory adapter #32285

Closed
wants to merge 14 commits into
base: master
from

Conversation

Projects
None yet
5 participants
@jagthedrummer
Contributor

jagthedrummer commented Mar 19, 2018

Summary

Adds an ActiveJob adapter for Faktory.

Other Information

Faktory is a language agnostic background job system. faktory_worker_ruby (https://github.com/contribsys/faktory_worker_ruby) provides a nice API for Ruby that is very similar to Sidekiq.

@rails-bot

This comment has been minimized.

rails-bot commented Mar 19, 2018

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @kaspth (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

This repository is being automatically checked for code quality issues using Code Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a Pull Request is considered ready to review.

Please see the contribution instructions for more information.

@jagthedrummer jagthedrummer changed the title from Jeremy/activejob faktory adapter to Faktory adapter Mar 19, 2018

jagthedrummer added some commits Mar 19, 2018

@jagthedrummer

This comment has been minimized.

Contributor

jagthedrummer commented Mar 19, 2018

I see that the aj:integration tests are failing on Travis. I assume that's because the faktory server isn't running on the Travis instance running the test. I'm not sure how to fix that, but I'd be happy to take a shot if someone can point me in the right direction.

@jagthedrummer

This comment has been minimized.

Contributor

jagthedrummer commented Mar 19, 2018

Oh, looks like .travis.yml is where I need to look. Trying to figure something out now.

jagthedrummer added some commits Mar 19, 2018

@jagthedrummer

This comment has been minimized.

Contributor

jagthedrummer commented Mar 19, 2018

Ok, got it figured out.

@y-yagi

This comment has been minimized.

Member

y-yagi commented Mar 19, 2018

I think Faktory is a nice background job system.

However, we have rejected it when there was a similar proposal about SQS before.
#21406 (comment)
#23311 (comment)

Therefore, instead of putting it in Rails, I think that it is better to add support in adapter(or gem).

@eileencodes

This comment has been minimized.

Member

eileencodes commented Mar 19, 2018

Hey @jagthedrummer thanks for taking the time to open the PR. @y-yagi is right, we don't generally accept new adapters into AJ because it becomes a bigger overhead for us. It's better to add support in the adapter itself rather than into Rails.

Thanks for understanding!

@jagthedrummer

This comment has been minimized.

Contributor

jagthedrummer commented Mar 19, 2018

Oh, bummer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment