Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move implementation of `before?` and `after?` to `DateAndTime::Calculations` #32398

Conversation

Projects
None yet
4 participants
@bogdanvlviv
Copy link
Contributor

commented Mar 31, 2018

This prevents duplication of code.

Prevent duplication of tests by moving them to DateAndTimeBehavior.

Related to #32185.

Move implementation of `before?` and `after?` to `DateAndTime::Calcul…
…ations`

This prevents duplication of code.

Prevent duplication of tests by moving them to `DateAndTimeBehavior`.

Related to #32185.
@rails-bot

This comment has been minimized.

Copy link

commented Mar 31, 2018

r? @eileencodes

(@rails-bot has picked a reviewer for you, use r? to override)

@kamipo kamipo merged commit 87d9228 into rails:master Mar 31, 2018

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
codeclimate All good!
Details
@bogdanvlviv

This comment has been minimized.

Copy link
Contributor Author

commented Apr 1, 2018

Thank you @kamipo@.

@bogdanvlviv bogdanvlviv deleted the bogdanvlviv:32185-dry-in-before-after-mehtods-implementation branch Apr 1, 2018

Samemura added a commit to Samemura/rails that referenced this pull request Jan 29, 2019

Samemura added a commit to Samemura/rails that referenced this pull request Feb 4, 2019

Samemura added a commit to Samemura/rails that referenced this pull request Feb 4, 2019

Samemura added a commit to Samemura/rails that referenced this pull request Feb 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.