Extract the confirm call in its own, overridable method in rails_ujs#32404
Extract the confirm call in its own, overridable method in rails_ujs#32404guilleiguaran merged 1 commit intorails:masterfrom
Conversation
|
Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @sgrif (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. This repository is being automatically checked for code quality issues using Code Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a Pull Request is considered ready to review. Please see the contribution instructions for more information. |
|
Any reason why this commit (91f4e33) has not been pulled into https://github.com/rails/rails/tree/5-2-stable? There's no risk of breaking any existing functionality and it's a useful enhancement for the |
|
This would have been so good to get into Rails 5.2. Is there any chance of that happening now? Rails 6 wasn't out when this one was merged. |
Following the discussion in #32402 and the inactivity of #29965, I added the possibility to override the
confirmcall in rails_ujs. This feature can be useful to anyone who want to customize the confirm dialog for example.The behaviour was possible with
jquery_ujsbut was missing fromrails_ujs.