Repository navigation
Add AR::Base.base_class? predicate - #32417
Merged
Merged
Conversation
|
(@rails-bot has picked a reviewer for you, use r? to override) |
Member
There was a problem hiding this comment.
Should this now return true instead of self?
kaspth
reviewed
Apr 2, 2018
| else | ||
| # STI subclasses always use their superclass' table. | ||
| base.table_name | ||
| base_class.table_name |
Contributor
There was a problem hiding this comment.
Is this a performance hot spot? Assuming the local variable is there for a reason 😅
Contributor
Author
There was a problem hiding this comment.
I think not: the result of this method is cached inside @table_name and L512 with its string construction is way slower than the else case.
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
base_class?can be handy addition to thebase_classwhich is the same asself == base_class.In my project
klass.base_class == klassis 50% the case of thebase_class. The same is actual for AR internally.