New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate support for using `HOST` environment to specify server IP #32540

Merged
merged 1 commit into from Apr 16, 2018

Conversation

Projects
None yet
3 participants
@y-yagi
Member

y-yagi commented Apr 12, 2018

At SuSE, $HOST is set by default and is equal to $HOSTNAME.
https://www.suse.com/documentation/sled11/book_sle_admin/data/sec_adm_variables.html

Therefore, by default, it binds to hostname instead of localhost. This seems not to be appropriate as default behavior.

In order to avoid the name of the environment variable being used, changed the environment variable from HOST to BINDING.

Fixes #29516.

Show outdated Hide outdated railties/lib/rails/commands/server/server_command.rb Outdated
Deprecate support for using `HOST` environment to specify server IP
At SuSE, `$HOST` is set by default and is equal to `$HOSTNAME`.
https://www.suse.com/documentation/sled11/book_sle_admin/data/sec_adm_variables.html

Therefore, by default, it binds to hostname instead of `localhost`.
This seems not to be appropriate as default behavior.

In order to avoid the name of the environment variable being used,
I changed the environment variable from `HOST` to `BINDING`.

Fixes #29516.

@y-yagi y-yagi merged commit 37b373a into rails:master Apr 16, 2018

2 checks passed

codeclimate All good!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@y-yagi y-yagi deleted the y-yagi:fix_29516 branch Apr 16, 2018

@GulajavaMinistudio GulajavaMinistudio referenced this pull request Apr 16, 2018

Merged

Update upstream #343

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment