URI.escape is obsolete : wanring removed #3265

Merged
merged 1 commit into from Oct 10, 2011

Conversation

Projects
None yet
3 participants
@arunagw
Member

arunagw commented Oct 9, 2011

URI.escape is obsolete : wanring removed

@vijaydev

This comment has been minimized.

Show comment Hide comment
@vijaydev

vijaydev Oct 9, 2011

Member

Please fix the typo in the commit message. And rebase the commit. This cannot be merged.

Member

vijaydev commented Oct 9, 2011

Please fix the typo in the commit message. And rebase the commit. This cannot be merged.

@arunagw

This comment has been minimized.

Show comment Hide comment
@arunagw

arunagw Oct 9, 2011

Member

@vijaydev Updated! Rebased!

Member

arunagw commented Oct 9, 2011

@vijaydev Updated! Rebased!

@@ -296,7 +296,7 @@ module ApplicationTests
precompile!
require "#{app_path}/config/environment"
- get "/assets/#{URI.escape(filename)}"
+ get "/assets/#{URI.parser.escape(filename)}"

This comment has been minimized.

Show comment Hide comment
@jeremy

jeremy Oct 9, 2011

Owner

Does this work in Ruby 1.8.7 also?

@jeremy

jeremy Oct 9, 2011

Owner

Does this work in Ruby 1.8.7 also?

This comment has been minimized.

Show comment Hide comment
@arunagw

arunagw Oct 9, 2011

Member

Running build locally now with 1.8.7.

@arunagw

arunagw Oct 9, 2011

Member

Running build locally now with 1.8.7.

This comment has been minimized.

Show comment Hide comment
@arunagw

arunagw Oct 9, 2011

Member

vijaydev added a commit that referenced this pull request Oct 10, 2011

Merge pull request #3265 from arunagw/warning_uri_parser
URI.escape is obsolete : warning removed

@vijaydev vijaydev merged commit b27ca99 into rails:master Oct 10, 2011

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment