Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unminify activestorage.js #32721

Merged
merged 1 commit into from Apr 25, 2018
Merged

Unminify activestorage.js #32721

merged 1 commit into from Apr 25, 2018

Conversation

@javan
Copy link
Member

@javan javan commented Apr 25, 2018

I feel like the best middle ground at this point would be making activestorage.js unminified as this PR originally did. We'll get more meaningful diffs for the compiled file in git (instead of diffs like f17137b), and the need for a source map mostly goes away.

Me

Closes #31707


Switches from webpack to rollup, which is better suited for building JavaScript libraries. Kudos to @gauravtiwari for proposing this change initially in #30253.

Closes #32391

@javan javan merged commit 13ec9fe into rails:master Apr 25, 2018
2 checks passed
javan added a commit that referenced this issue Aug 19, 2018
Unminify activestorage.js
# Conflicts:
#	activestorage/app/assets/javascripts/activestorage.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant