Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport "save attributes changed by callbacks after update_attribute" #32871

Merged
merged 1 commit into from May 11, 2018

Conversation

@tarebyte
Copy link

tarebyte commented May 11, 2018

This backports #27780 to the 5.0.x series.

/cc @eileencodes & @tenderlove

@rails-bot

This comment has been minimized.

Copy link

rails-bot commented May 11, 2018

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @pixeltrix (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

This repository is being automatically checked for code quality issues using Code Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a Pull Request is considered ready to review.

Please see the contribution instructions for more information.

@rails-bot

This comment has been minimized.

Copy link

rails-bot commented May 11, 2018

warning Warning warning

  • Pull requests are usually filed against the master branch for this repo, but this one is against 5-0-stable. Please double check that you specified the right target!
@eileencodes eileencodes assigned eileencodes and unassigned pixeltrix May 11, 2018
@tenderlove tenderlove merged commit b21aa9b into rails:5-0-stable May 11, 2018
1 check failed
1 check failed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
@tarebyte tarebyte deleted the tarebyte:backport-update_attribute branch May 11, 2018
@chrismhilton

This comment has been minimized.

Copy link

chrismhilton commented Nov 18, 2019

Any reason this commit didn't make it into the 5.0.7.1 (november 2018) or 5.0.7.2 (march 2019) release? Sorry if this isn't the right place to ask this question.

@eileencodes

This comment has been minimized.

Copy link
Member

eileencodes commented Nov 18, 2019

Those are security releases @chrismhilton so we don't add bug fixes or improvements to those versions.

@chrismhilton

This comment has been minimized.

Copy link

chrismhilton commented Nov 18, 2019

Thanks for the quick answer @eileencodes so do you happen to know why there hasn't been a 5.0.8 release?

@eileencodes

This comment has been minimized.

Copy link
Member

eileencodes commented Nov 18, 2019

Because it's no longer supported. If you're still using 5.0.8 you should upgrade as currently only 5.2 and 6.0 are supported for security releases, and 6.0 for bug fixes.

You can see our maintenance policy here https://guides.rubyonrails.org/maintenance_policy.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.