fixes error when can't unmarshal session contents #3298

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants

Hi there,

when Marshal.load can't read an object, it raises an ArgumentError. This is happening after migrating from rails 3.0.x to 3.1, when the session contains a FlashHash object. That's because FlashHash doesn't inherit from Hash anymore (see 76c2ea7) - related issue: #2509

I couldn't write a test to reproduce it, unfortunately - and I couldn't find any test exercising this portion of the code. Maybe somebody more used to the codebase?

Best!
Bruno

@josevalim josevalim added a commit that referenced this pull request Oct 12, 2011

@josevalim josevalim Provide failing test case for #3298 #2509 86a5271

josevalim closed this in 4cdc31c Oct 12, 2011

@waseem waseem pushed a commit to waseem/rails that referenced this pull request Oct 12, 2011

@josevalim josevalim Add some implementation docs. closes #3298. closes #2509. 2cb2ca6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment