Make Webpacker the default JavaScript compiler for Rails 6 by dhh · Pull Request #33079 · rails/rails

dhh · 2018-06-07T14:21:29Z

Make Webpacker the default Javascript compiler for Rails 6 with the following changes:

Webpacker gem is installed by default and webpacker:install is run by the Rails application generator.
Action Cable channel generators will create ES6 stubs rather than use CoffeeScript
Active Storage, Action Cable, Turbolinks, and Rails-UJS is loaded by a new application.js pack in app/javascript by default (unless any of the frameworks have been opted out).
Active Storage, Action Cable, Turbolinks, and Rails-UJS npm modules are automatically listed as dependencies in the default package.json.
All the JavaScript-related auxiliaries for Sprockets, like compression and uglifying, is no longer configured or included by default.
No JavaScript stubs will be created by default when using the scaffold generators any more.

…ramework setup now

@javan

Need some work on how to set the global consumer that channels will work with. @javan?

yhirano55 · 2018-06-07T21:21:08Z

-        else
-          GemfileEntry.new "mini_racer", nil, comment, { platforms: :ruby }, true
+          [ GemfileEntry.version("turbolinks", "~> 5",
+             "Turbolinks makes navigating your web application faster. Read more: https://github.com/turbolinks/turbolinks") ]


Turbolinks is added on package.json, so it looks unnecessary to add turbolinks to Gemfile.

I see. Thanks. https://github.com/turbolinks/turbolinks-rails

dhh · 2018-06-07T21:39:48Z

There’s a Ruby and a JS component. Both are needed.

…

On Jun 7, 2018, at 23:23, yhirano55 ***@***.***> wrote: @yhirano55 commented on this pull request. In railties/lib/rails/generators/app_base.rb: > - end - - gems - end - end - - def javascript_runtime_gemfile_entry - comment = "See https://github.com/rails/execjs#readme for more supported runtimes" - if defined?(JRUBY_VERSION) - GemfileEntry.version "therubyrhino", nil, comment - elsif RUBY_PLATFORM =~ /mingw|mswin/ - GemfileEntry.version "duktape", nil, comment - else - GemfileEntry.new "mini_racer", nil, comment, { platforms: :ruby }, true + [ GemfileEntry.version("turbolinks", "~> 5", + "Turbolinks makes navigating your web application faster. Read more: https://github.com/turbolinks/turbolinks") ] Turbolinks is added on package.json, so it looks unnecessary to add turbolinks to Gemfile. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

dhh · 2018-06-19T11:02:17Z

Because JavaScript is a language, not a classification of a domain type, like controllers or views or models. JavaScript has all those things. Saying "JavaScripts" imply that it's a collection of isolated, independent files, when it's not. It's the part of the application written in JavaScript.

…

On Fri, Jun 15, 2018 at 6:18 PM, Rainer Borene ***@***.***> wrote: @dhh <https://github.com/dhh> any reason to keep the javascript folder name in singular? why not following the pattern of plural name like controllers, models and views? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#33079 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAAKtdNf_Y4N_9wLEZE3ZnZR08tvrNhiks5t895pgaJpZM4UegdM> .

rainerborene · 2018-06-25T13:24:39Z

@dhh that means that sprockets will no longer be a dependency on Rails?

dhh · 2018-06-25T13:29:38Z

No, Sprockets is still to be used for SCSS (and other CSS processors) as well as copying all other static assets.

…

On Mon, Jun 25, 2018 at 3:25 PM, Rainer Borene ***@***.***> wrote: @dhh <https://github.com/dhh> that means that sprockets will no longer be a dependency on Rails? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#33079 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAAKtUSOtzstvc81TfoLi1IQVNJijU_Zks5uAOTngaJpZM4UegdM> .

shashiprab · 2018-11-29T22:22:57Z

@dhh keeping my eyes peeled for the promised new JS framework for Rails 6.0 reveal! (Haven't found anything satisfying so far with either React, or Stimulus or Ember - hope its a new "Rails Way" framework)

dhh · 2018-11-29T22:35:47Z

It's been revealed! https://www.youtube.com/watch?v=HJZ9TnKrt7Q There's another Rails 6 reveal in the wings still, but that's not a JS related framework.

…

On Thu, Nov 29, 2018 at 2:24 PM Shashi Prabhakar ***@***.***> wrote: @dhh <https://github.com/dhh> keeping my eyes peeled for the promised new JS framework for Rails 6.0 reveal! (Haven't found anything satisfying so far with either React, or Stimulus or Ember - hope its a new "Rails Way" framework) — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#33079 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAAKtSfFeAoI1p87DRkq8ikb7a14INOPks5u0F6LgaJpZM4UegdM> .

Fix path to channel files. `rails generate channel Chat` generates `app/javascript/channels/chat_channel.js`. See also, railties/lib/rails/generators/rails/app/templates/app/javascript/packs/application.js.tt, actioncable/lib/rails/generators/channel/templates/javascript/index.js.tt by default `application.js` imports "channels", where `app/javascript/channels/index.js` loads all the channels within this directory and all subdirectories. Follow up rails#34709 Related to rails#33079

Make Webpacker the default JavaScript compiler for Rails 6 rails/rails#33079

webpacker will be the default JavaScript compiler for Rails 6: - rails/rails#33079 Note, webpacker and the asset pipeline can run side-by-side. - webpacker and yarn are now used to manage: jquery, rails-ujs, turbolinks and local-time JavaScript libraries. - jQuery is exported globally from webpacker and is used in the asset pipeline and JS remote responses - the album tracks visibility JS sprinkle is now ES6 served by webpacker instead CoffeeScript via the asset pipeline. Upcoming work: - Move/convert all CoffeeScript sprinkles from the asset pipeline to ES6 via webpacker - Replace Gemified Bootstrap via the asset pipeline with yarn and webpacker managed Bootstrap (v3) - Move images and stylesheets from the asset pipeline to webpacker - Delete the asset pipeline

seems like webpacker is increasingly the way to go for new js/css asset work in rails with it being the default in rails 6, so lets start working on transitioning to better practices and get some rewrites of the old code in ( rails/rails#33079 )

David Heinemeier Hansson added 12 commits June 7, 2018 14:58

Use Webpacker by default on new apps

aff5bd1

Stop including coffee-rails by default

1c394c6

Drop using a js_compressor by default

00d6277

Drop extra test for coffeescript inclusion by default

b9df2ba

Stick with skip_javascript to signify skipping webpack

32da660

Don't install a JS runtime by default any more

309fc6f

app/javascript will be the new default directory for JS

178cfb1

Make it clear that this is just for configuring the default Webpack f…

cc61568

…ramework setup now

Start using the Webpack tag in the default layout

6f8009d

Irrelevant test

1b79740

jQuery is long gone

55d5a95

Stop having asset pipeline compile default application.js

d2a9456

dhh added this to the 6.0.0 milestone Jun 7, 2018

David Heinemeier Hansson added 5 commits June 7, 2018 18:04

Add rails-ujs by default to the Webpack setup

221fce1

Add Active Storage JavaScript to application.js pack by default

6a6cc8c

Consistent quoting

b4a15a3

Add Turbolinks to default pack

7486cc9

Add Action Cable to default pack

218a8e2

Need some work on how to set the global consumer that channels will work with. @javan?

yhirano55 reviewed Jun 7, 2018

View reviewed changes

rafaelfranca added railties asset pipeline labels Jun 8, 2018

Require all channels by default and use a separate consumer stub

c0fa838

David Heinemeier Hansson added 4 commits June 25, 2018 14:45

Channel generator now targets Webpack style

49a1803

Merge branch 'master' into webpacker-default

2ee0987

Update task docs to match new generator style

d55d84b

Use uniform import style

6896743

coorasse mentioned this pull request Oct 27, 2018

Ruby Sass End-of-Life: 26 March 2019 rails/sass-rails#420

Closed

scarroll32 mentioned this pull request Nov 13, 2018

Road to Rails 6 activeadmin/activeadmin#5558

Closed

jakeNiemiec mentioned this pull request Dec 14, 2018

Stable webpacker 4.0 release rails/webpacker#1823

Merged

5 tasks

ameft mentioned this pull request Dec 18, 2018

Rename javascript folder to frontend rails/webpacker#1833

Closed

bogdanvlviv mentioned this pull request Jan 13, 2019

Fix "Action Cable Overview" guide [ci skip] #34932

Merged

dankmitchell mentioned this pull request Feb 7, 2019

Webpacker support solidusio/solidus#3077

Closed

atxrenegade mentioned this pull request Feb 16, 2019

Rails 6 Webpacker will replace Sprockets as the default JavaScript compiler learn-co-curriculum/what-is-the-asset-pipeline#18

Open

bogdanvlviv mentioned this pull request Mar 5, 2019

rails new with --skip-webpack-install still includes the webpacker gem. #35484

Closed

This was referenced Mar 20, 2019

Revert "Revert "Remove javascripts and javascript_engine options for generators"" #35675

Merged

Skip CoffeeScript generate tests for Rails >= 6 rails/coffee-rails#106

Closed

This was referenced Apr 4, 2019

Resurrect external JS/CS generation #35852

Merged

Rails 6 support rails/coffee-rails#114

Merged

rafaelfranca mentioned this pull request Apr 8, 2019

Expected skeletons are not built with rails plugin new blorgh --mountable #35894

Closed

schpet mentioned this pull request Apr 25, 2019

Clarity around asset pipeline and webpacker TanookiLabs/tanooki-rails-template#14

Closed

suketa added a commit to suketa/rails_sandbox that referenced this pull request Jun 15, 2019

Rails 6.0.0rc1 try038

b119231

Make Webpacker the default JavaScript compiler for Rails 6 rails/rails#33079

suketa added a commit to suketa/rails_sandbox that referenced this pull request Jun 16, 2019

Rails 6.0.0rc1 bootstrap step2

24ee5ad

Make Webpacker the default JavaScript compiler for Rails 6 rails/rails#33079

udaykadaboina mentioned this pull request Aug 22, 2019

modified installation instructions for rails6 reactjs/react-rails#1018

Merged

lacostenycoder mentioned this pull request Feb 19, 2020

Stop using CoffeeScript in Rails Guides #38514

Closed

DmitryKey mentioned this pull request Jun 12, 2021

Research webpack (and possibly integrate it) o19s/quepid#318

Closed

BrentWheeldon mentioned this pull request Oct 26, 2022

Generator options with duplicate values get messed up in test helper #46347

Closed

tnir mentioned this pull request May 23, 2024

chore: remove webpack from yarn dependencies in Rails dev #51885

Merged

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Make Webpacker the default JavaScript compiler for Rails 6#33079

Make Webpacker the default JavaScript compiler for Rails 6#33079
dhh merged 54 commits intomasterfrom
webpacker-default

dhh commented Jun 7, 2018 •

edited

Loading

Uh oh!

yhirano55 Jun 7, 2018

Uh oh!

yhirano55 Jun 7, 2018

Uh oh!

dhh commented Jun 7, 2018 via email

Uh oh!

dhh commented Jun 19, 2018 via email

Uh oh!

rainerborene commented Jun 25, 2018

Uh oh!

dhh commented Jun 25, 2018 via email

Uh oh!

shashiprab commented Nov 29, 2018

Uh oh!

dhh commented Nov 29, 2018 via email

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

Conversation

dhh commented Jun 7, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

yhirano55 Jun 7, 2018

Choose a reason for hiding this comment

Uh oh!

yhirano55 Jun 7, 2018

Choose a reason for hiding this comment

Uh oh!

dhh commented Jun 7, 2018 via email

Uh oh!

dhh commented Jun 19, 2018 via email

Uh oh!

rainerborene commented Jun 25, 2018

Uh oh!

dhh commented Jun 25, 2018 via email

Uh oh!

shashiprab commented Nov 29, 2018

Uh oh!

dhh commented Nov 29, 2018 via email

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

dhh commented Jun 7, 2018 •

edited

Loading