Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
PostgreSQL: prepare for pg-1.1 #33188
pg-1.1 is planned to deprecate some behavior. I (tried to) discussed this here. It currently warns at every method invocation, but I plan to change it to warm only once and to add an environment variable to disable the warning entirely. I'm also open to disable the most prominent warning about async_exec vs. async_exec_params until the next rails-5.x releases are out.
referenced this pull request
Jun 22, 2018
Yeah I think my suggestion (and I'm aware this is coming from a maintainer of a very deprecation-happy project) would be to keep the old names working at least for one more release series, as they don't seem to be "in the way" / occupying names you want to reuse with different semantics.
I think we're currently semi-unofficially still mostly maintaining 5.0, so a full 5.x backport isn't impossible... but it does seem a bit pointless: much as 4.2 doesn't support 1.x, 5.x doesn't support pg 2.x -- so it's a warning about a change that code will never encounter.
Lars, thinking about this, perhaps we simply strip the warning for now from 1.1 (and re-introduce with 2.0) and then "eat" the behavior change with malformed arrays on upgrade of PG
The trouble of getting this into Rails and backported is that we will be that we are 100% blocked on releasing PG 1.1 till a new gem is cut for 5.X, this usually only happens when there is a security flaw found. It could be months.
I think for Rails 6.0 we should change it so malformed arrays are malformed arrays and raise properly, nuking that weird test.