New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes Rails Welcome image on localhost:3000 #33191

Merged
merged 1 commit into from Jun 24, 2018

Conversation

Projects
None yet
4 participants
@bogdanvlviv
Contributor

bogdanvlviv commented Jun 22, 2018

Note that I used https://www.base64-image.de/ in order to
convert the image to Base64 with enabled optimization status.

Closes #33181.
Closes #33186.
Follow up #32735.

The image:
rails_welcome

Before:
screenshot from 2018-06-22 14-56-34

After:
screenshot from 2018-06-22 15-00-42

Changes Rails Welcome image on localhost:3000
Note that I used https://www.base64-image.de/ in order to
convert the image to Base64 with enabled optimization status.

Closes #33181.
Closes #33186.
Follow up #32735.
@rails-bot

This comment has been minimized.

Show comment
Hide comment
@rails-bot

rails-bot Jun 22, 2018

r? @sgrif

(@rails-bot has picked a reviewer for you, use r? to override)

rails-bot commented Jun 22, 2018

r? @sgrif

(@rails-bot has picked a reviewer for you, use r? to override)

@georgeclaghorn georgeclaghorn merged commit 8888fc0 into rails:master Jun 24, 2018

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
codeclimate All good!
Details

@bogdanvlviv bogdanvlviv deleted the bogdanvlviv:change-rails_welcome-image-on-localhost3000 branch Jun 24, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment