GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
Already on GitHub? Sign in to your account
Don't quote IDs as Arel will quote them -- follow same conventions as the delete method, which is already in place. This causes problems when working with strings as primary keys which are then quoted twice.
Included is a patch to resolve this issue. The delete method uses ID, not quoted ID, as ARel will quote it.
Don't quote ID's as Arel will quote them -- follow same conventions as
the delete method.
@tenderlove and @jonleighton ❤️
@cmeiklejohn can you add a test please?
Add new model to represent table with string as primary key.
Add test coverage to ensure optimistic locking works with strings for
Added. Had to add a new model to represent the table with a string for primary key -- also added coverage to the destroy call as well. Let me know if you'd like to see anything renamed or changed.
Merge pull request #332 from cmeiklejohn/bug6230_optimistic_locking_d…
Oops, meant to say the following at the same time as closing:
Merged, thanks! I condensed it into a single commit so it's clearer to other people that the tests are associated with the fix.
Merge commit: a8daea4