fix inconsistent alignment in Gemfile generator #3320

Merged
merged 1 commit into from Oct 15, 2011

Projects

None yet

2 participants

Contributor
sunaku commented Oct 13, 2011

I got tired of seeing this inconsistently aligned code that is produced by rails new in Gemfile:

# Bundle edge Rails instead:
# gem 'rails',     :git => 'git://github.com/rails/rails.git'

Just to be clear, I'm talking about the whitespace after the comma and before the :git above.

This commit fixes it.

Member

Some people prefer to have the options aligned. Thanks for the pull request but I am closing this because it is simply a style change.

@josevalim josevalim closed this Oct 13, 2011
Contributor
sunaku commented Oct 13, 2011

Okay, I updated my commit to only include the glaring change that was bothering me (it's one line of output, so it's out of alignment with itself). Please reconsider now!

Member

This still removes the alignment for :git and :path options for rails and journey.

Contributor
sunaku commented Oct 14, 2011

Looks like a bug in GitHub (the commit attached to this pull request hasn't been updated --- maybe because the request was closed?). I force-pushed an updated commit to this branch 15 hours ago. Please review that and cherry-pick or merge, as you please. Thanks.

Member

Ok, tks!

@josevalim josevalim reopened this Oct 14, 2011
@josevalim josevalim merged commit 098c95a into rails:master Oct 15, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment