New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bundler binstubs #33202

Merged
merged 3 commits into from Aug 11, 2018

Conversation

Projects
None yet
3 participants
@deivid-rodriguez
Contributor

deivid-rodriguez commented Jun 23, 2018

Summary

This PR generates a bundler-compatible bundler binstub on new applications. Fixes #31193.

@rails-bot

This comment has been minimized.

Show comment
Hide comment
@rails-bot

rails-bot Jun 23, 2018

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @eileencodes (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

This repository is being automatically checked for code quality issues using Code Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a Pull Request is considered ready to review.

Please see the contribution instructions for more information.

rails-bot commented Jun 23, 2018

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @eileencodes (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

This repository is being automatically checked for code quality issues using Code Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a Pull Request is considered ready to review.

Please see the contribution instructions for more information.

@eileencodes eileencodes merged commit 920c919 into rails:master Aug 11, 2018

2 checks passed

codeclimate All good!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

bogdanvlviv added a commit to bogdanvlviv/rails that referenced this pull request Aug 11, 2018

`bundle binstubs bundler` should be executed after `bundle install`
Fixes:

`bundle binstubs bundler` doesn't generate `bin/bundle` for newly
generated Rails app.

```
...
(snip)
run  bundle binstubs bundler
The git source https://github.com/rails/web-console.git is not yet checked out.
Please run `bundle install` before trying to start your application
run  bundle install
Fetching https://github.com/rails/web-console.git
(snip)
...
```

Related to rails#33202

@deivid-rodriguez deivid-rodriguez deleted the deivid-rodriguez:bundler_binstubs branch Aug 11, 2018

@deivid-rodriguez

This comment has been minimized.

Show comment
Hide comment
@deivid-rodriguez

deivid-rodriguez Aug 11, 2018

Contributor

Thanks so much @eileencodes! There was an problem with the PR though (I thought I tried it manually, but apparently not... 😳), @bogdanvlviv kindly fixed it in #33587.

Contributor

deivid-rodriguez commented Aug 11, 2018

Thanks so much @eileencodes! There was an problem with the PR though (I thought I tried it manually, but apparently not... 😳), @bogdanvlviv kindly fixed it in #33587.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment