Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix default value for mysql time types with specified precision #33280

Merged
merged 1 commit into from Jul 8, 2018

Conversation

@nkondratyev
Copy link
Contributor

@nkondratyev nkondratyev commented Jul 3, 2018

Summary

The TIME, DATETIME, and TIMESTAMP types have supported
a fractional seconds precision from 0 to 6.

Default values from time columns with specified precision is read
as current_timestamp(n) from information schema.

Current behavior

rake db:schema:dump produces schema.rb without default values for time columns with the specified precision:

t.datetime "last_message_at", precision: 6, null: false

Expected behavior

rake db:schema:dump produces schema.rb with default values for time columns with the specified precision:

t.datetime "last_message_at", precision: 6, default: -> { "current_timestamp(6)" }, null: false
@rails-bot
Copy link

@rails-bot rails-bot commented Jul 3, 2018

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @pixeltrix (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

This repository is being automatically checked for code quality issues using Code Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a Pull Request is considered ready to review.

Please see the contribution instructions for more information.

The TIME, DATETIME, and TIMESTAMP types [have supported](https://mariadb.com/kb/en/library/microseconds-in-mariadb/)
a fractional seconds precision from 0 to 6.

Default values from time columns with specified precision is read
as `current_timestamp(n)` from information schema.

rake `db:schema:dump` produces `schema.rb` **without** default values for time columns with the specified precision:

    t.datetime "last_message_at", precision: 6, null: false

rake `db:schema:dump` produces `schema.rb` **with** default values for time columns with the specified precision:

    t.datetime "last_message_at", precision: 6, default: -> { "current_timestamp(6)" }, null: false
@nkondratyev nkondratyev force-pushed the fix/mysql-time-default-values branch from 6615cb3 to 64078e0 Jul 4, 2018
@kamipo kamipo merged commit 64078e0 into rails:master Jul 8, 2018
2 checks passed
kamipo added a commit that referenced this issue Jul 8, 2018
Fix default value for mysql time types with specified precision
@kamipo
Copy link
Member

@kamipo kamipo commented Jul 8, 2018

Thanks!

kamipo added a commit that referenced this issue Jul 8, 2018
Fix default value for mysql time types with specified precision
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants