Fix default value for mysql time types with specified precision#33280
Fix default value for mysql time types with specified precision#33280kamipo merged 1 commit intorails:masterfrom
Conversation
|
Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @pixeltrix (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. This repository is being automatically checked for code quality issues using Code Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a Pull Request is considered ready to review. Please see the contribution instructions for more information. |
The TIME, DATETIME, and TIMESTAMP types [have supported](https://mariadb.com/kb/en/library/microseconds-in-mariadb/) a fractional seconds precision from 0 to 6. Default values from time columns with specified precision is read as `current_timestamp(n)` from information schema. rake `db:schema:dump` produces `schema.rb` **without** default values for time columns with the specified precision: t.datetime "last_message_at", precision: 6, null: false rake `db:schema:dump` produces `schema.rb` **with** default values for time columns with the specified precision: t.datetime "last_message_at", precision: 6, default: -> { "current_timestamp(6)" }, null: false
6615cb3 to
64078e0
Compare
Fix default value for mysql time types with specified precision
|
Thanks! |
Fix default value for mysql time types with specified precision
Summary
The TIME, DATETIME, and TIMESTAMP types have supported
a fractional seconds precision from 0 to 6.
Default values from time columns with specified precision is read
as
current_timestamp(n)from information schema.Current behavior
rake
db:schema:dumpproducesschema.rbwithout default values for time columns with the specified precision:Expected behavior
rake
db:schema:dumpproducesschema.rbwith default values for time columns with the specified precision: