Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize the date component to 2000-01-01 automatically #33358

Merged
merged 2 commits into from Jul 18, 2018

Conversation

Projects
None yet
5 participants
@azbshiri
Copy link
Contributor

commented Jul 14, 2018

Summary

Fixes #32550 - Normalize the date component to 2000-01-01 automatically when searching by that column by using change.

Other Information

N/A

@rails-bot

This comment has been minimized.

Copy link

commented Jul 14, 2018

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @kamipo (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

This repository is being automatically checked for code quality issues using Code Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a Pull Request is considered ready to review.

Please see the contribution instructions for more information.

@azbshiri azbshiri changed the title Test first Normalize the date component to 2000-01-01 automatically Jul 14, 2018

@azbshiri

This comment has been minimized.

Copy link
Contributor Author

commented Jul 15, 2018

would you take a look at this?
@pixeltrix @rafaelfranca

@rafaelfranca

This comment has been minimized.

Copy link
Member

commented Jul 16, 2018

Thanks! I like the improvements you did but I feel it is better to merge the PR of the original author and work on top of it instead of redoing the patch and not giving the credits. Can you do that? You can cherry pick his commits, squash them in one and apply your commit on top.

SeanPrashad and others added some commits Apr 18, 2018

Test DST both in local and utc timezone
Also?
Updated failing test.

@azbshiri azbshiri force-pushed the azbshiri:summer-time branch to 35ca222 Jul 17, 2018

@azbshiri

This comment has been minimized.

Copy link
Contributor Author

commented Jul 17, 2018

@rafaelfranca rafaelfranca merged commit daee94d into rails:master Jul 18, 2018

2 checks passed

codeclimate All good!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

rafaelfranca added a commit that referenced this pull request Jul 18, 2018

Merge pull request #33358 from azbshiri/summer-time
Normalize the date component to 2000-01-01 automatically

rafaelfranca added a commit that referenced this pull request Jul 18, 2018

Merge pull request #33358 from azbshiri/summer-time
Normalize the date component to 2000-01-01 automatically

kamipo added a commit that referenced this pull request Jul 25, 2018

kamipo added a commit that referenced this pull request Jul 25, 2018

kamipo added a commit that referenced this pull request Aug 29, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.