New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow subclasses to redefine autosave callbacks for associated records #33378

Merged
merged 1 commit into from Sep 13, 2018

Conversation

Projects
None yet
4 participants
@numbata
Contributor

numbata commented Jul 17, 2018

Summary

This addresses this issue #33305

AutosaveAssociation skip creation of callback method if it's already defined (even in parent class).

@rails-bot

This comment has been minimized.

Show comment
Hide comment
@rails-bot

rails-bot Jul 17, 2018

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @rafaelfranca (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

This repository is being automatically checked for code quality issues using Code Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a Pull Request is considered ready to review.

Please see the contribution instructions for more information.

rails-bot commented Jul 17, 2018

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @rafaelfranca (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

This repository is being automatically checked for code quality issues using Code Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a Pull Request is considered ready to review.

Please see the contribution instructions for more information.

Show outdated Hide outdated activerecord/CHANGELOG.md
Show outdated Hide outdated activerecord/test/cases/autosave_association_test.rb
Show outdated Hide outdated activerecord/test/cases/autosave_association_test.rb
Show outdated Hide outdated activerecord/test/cases/autosave_association_test.rb
Show outdated Hide outdated activerecord/test/cases/autosave_association_test.rb
@bogdanvlviv

This comment has been minimized.

Show comment
Hide comment
@bogdanvlviv

bogdanvlviv Jul 17, 2018

Contributor

Could you squash commits into one?

Contributor

bogdanvlviv commented Jul 17, 2018

Could you squash commits into one?

Show outdated Hide outdated activerecord/test/cases/autosave_association_test.rb

@rafaelfranca rafaelfranca merged commit 35ee756 into rails:master Sep 13, 2018

2 checks passed

codeclimate All good!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

rafaelfranca added a commit that referenced this pull request Sep 13, 2018

Merge pull request #33378 from numbata/subclass-redefine-autosave-cal…
…lbacks

Allow subclasses to redefine autosave callbacks for associated records
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment