Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call build when extend with nested attributes defined #33454

Merged
merged 1 commit into from Aug 5, 2018

Conversation

@gigantik
Copy link
Contributor

@gigantik gigantik commented Jul 26, 2018

Summary

What?
Fixes #33389 - From now on when accepts_nested_attributes_for defined and extend option
added the overwritten build method being called.

@rails-bot
Copy link

@rails-bot rails-bot commented Jul 26, 2018

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @schneems (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

This repository is being automatically checked for code quality issues using Code Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a Pull Request is considered ready to review.

Please see the contribution instructions for more information.

@gigantik gigantik force-pushed the gigantik:extend-affects-nested-attributes branch 2 times, most recently Jul 27, 2018
@gigantik
Copy link
Contributor Author

@gigantik gigantik commented Jul 27, 2018

@schneems Hi buddy would you please check out this PR?

@Edouard-chin
Copy link
Member

@Edouard-chin Edouard-chin commented Aug 1, 2018

Dug a bit and the change make sense

What?
From now on when `accepts_nested_attributes_for` defined and `extend` option
added the overwritten `build` method being called.

[Alireza Bashiri, Martins Polakovs]
@gigantik gigantik force-pushed the gigantik:extend-affects-nested-attributes branch to dc16cdd Aug 2, 2018
@gigantik
Copy link
Contributor Author

@gigantik gigantik commented Aug 2, 2018

@kamipo done.

@schneems
Copy link
Member

@schneems schneems commented Aug 5, 2018

Thanks!

@schneems schneems merged commit a2b9768 into rails:master Aug 5, 2018
2 checks passed
2 checks passed
codeclimate All good!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@clowder
Copy link

@clowder clowder commented Dec 4, 2018

@schneems Would it be possible to get this fix backported into 5-2-stable?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
You can’t perform that action at this time.