Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve ActiveStorage service adapter error handling #33540


Copy link

@joeltaylor joeltaylor commented Aug 7, 2018


Addresses #33157

  • Allows for service names to be either lowercase or capitalized
  • Raises an error if the service cannot be loaded and provides an explicit message

Other Information

Not entirely certain if lower and capital cases should be accepted, but figured I'd give it a shot to see if anyone finds it useful.

Copy link

@rails-bot rails-bot commented Aug 7, 2018

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @kaspth (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

This repository is being automatically checked for code quality issues using Code Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a Pull Request is considered ready to review.

Please see the contribution instructions for more information.

@georgeclaghorn georgeclaghorn merged commit 1ed33a2 into rails:master Aug 7, 2018
2 checks passed
2 checks passed
codeclimate All good!
continuous-integration/travis-ci/pr The Travis CI build passed
Copy link

@georgeclaghorn georgeclaghorn commented Aug 7, 2018

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants