New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let escape_javascript handle conversion to string #33564

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
4 participants
@avit
Contributor

avit commented Aug 9, 2018

Summary

This brings escape_javascript in line with the behavior of json_escape and
allows other value types to be output without needing explicit casting in the
view template.

Example:

<%= javascript_tag do %>
  var locale = '<%== j I18n.locale %>'; // locale is a symbol
<% end %>

Other Information

The above example currently raises an error for undefined method gsub which seems surprising when compared to other output helpers.

Ironically, I think it is json_escape that should be more strict about the type of parameters it receives, since it should only expect serialized (to_json) values. That is not addressed here, but I mention it for comparison.

@rails-bot

This comment has been minimized.

Show comment
Hide comment
@rails-bot

rails-bot Aug 9, 2018

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @pixeltrix (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

This repository is being automatically checked for code quality issues using Code Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a Pull Request is considered ready to review.

Please see the contribution instructions for more information.

rails-bot commented Aug 9, 2018

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @pixeltrix (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

This repository is being automatically checked for code quality issues using Code Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a Pull Request is considered ready to review.

Please see the contribution instructions for more information.

Let escape_javascript handle conversion to string
This brings `escape_javascript` in line with the behavior of `json_escape` and
allows other value types to be output without needing explicit casting in the
view template.

Example:

    <%= javascript_tag do %>
      var locale = '<%== j I18n.locale %>'; // locale is a symbol
    <% end %>
@FancyCoder0

This comment has been minimized.

Show comment
Hide comment
@FancyCoder0

FancyCoder0 Sep 15, 2018

Hi Andrew Vit(@avit ) & Andrew White pixeltrix(@pixeltrix ),
We are researchers working on identifying redundant development and duplicated pull requests. We have found there is a pull request: #17679 which might be a potentially duplicate to this one. We would like to build the link between developers to reduce redundant development. We would really appreciate if you could help us to validate and give us feedback.
Thank you very much for your time!

FancyCoder0 commented Sep 15, 2018

Hi Andrew Vit(@avit ) & Andrew White pixeltrix(@pixeltrix ),
We are researchers working on identifying redundant development and duplicated pull requests. We have found there is a pull request: #17679 which might be a potentially duplicate to this one. We would like to build the link between developers to reduce redundant development. We would really appreciate if you could help us to validate and give us feedback.
Thank you very much for your time!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment