SQLite3 adapter alter_table method restores foreign keys#33585
Merged
kamipo merged 1 commit intorails:masterfrom Aug 16, 2018
Merged
SQLite3 adapter alter_table method restores foreign keys#33585kamipo merged 1 commit intorails:masterfrom
alter_table method restores foreign keys#33585kamipo merged 1 commit intorails:masterfrom
Conversation
|
(@rails-bot has picked a reviewer for you, use r? to override) |
eileencodes
requested changes
Aug 11, 2018
Member
eileencodes
left a comment
eileencodes
left a comment
There was a problem hiding this comment.
Looks good. Can you add a change log entry?
Member
There was a problem hiding this comment.
Can you add a space before and after this block? Like this:
end
if options[:foreign_keys]
...
end
yield
Member
Author
|
Thanks for the review. Added a new changelog entry and made changes as suggested. |
Contributor
|
r? @eileencodes |
kamipo
added a commit
that referenced
this pull request
Aug 16, 2018
SQLite3 adapter `alter_table` method restores foreign keys
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SQLite3 adapter
alter_tablemethod restores foreign keys.Rails 6 supports SQLite database 3.8 or higher which allows executing
alter_tablemethod for foreign key referenced - "parent" tables. This pull request enablesalter_tablemethod for foreign keys referencing - "child" tables.Related to #33520, this pull request does not support renaming columns for foreign keys.